2022-11-19 00:42:10

by Uwe Kleine-König

[permalink] [raw]
Subject: [PATCH 132/606] iio: light: max44009: Convert to i2c's .probe_new()

From: Uwe Kleine-König <[email protected]>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/iio/light/max44009.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/light/max44009.c b/drivers/iio/light/max44009.c
index 801e5a0ad496..3dadace09fe2 100644
--- a/drivers/iio/light/max44009.c
+++ b/drivers/iio/light/max44009.c
@@ -487,8 +487,7 @@ static irqreturn_t max44009_threaded_irq_handler(int irq, void *p)
return IRQ_NONE;
}

-static int max44009_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int max44009_probe(struct i2c_client *client)
{
struct max44009_data *data;
struct iio_dev *indio_dev;
@@ -538,7 +537,7 @@ static struct i2c_driver max44009_driver = {
.driver = {
.name = MAX44009_DRV_NAME,
},
- .probe = max44009_probe,
+ .probe_new = max44009_probe,
.id_table = max44009_id,
};
module_i2c_driver(max44009_driver);
--
2.38.1



2022-12-06 11:41:00

by Uwe Kleine-König

[permalink] [raw]
Subject: Re: [PATCH 132/606] iio: light: max44009: Convert to i2c's .probe_new()

Hello Jonathan,

On Fri, Nov 18, 2022 at 11:37:46PM +0100, Uwe Kleine-K?nig wrote:
> drivers/iio/light/max44009.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)

all iio patches from my series but this one are applied in next now. I
wonder what happend to that one, my best guess is that this patch was
dropped by accident?

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |


Attachments:
(No filename) (528.00 B)
signature.asc (499.00 B)
Download all attachments

2022-12-11 11:42:07

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH 132/606] iio: light: max44009: Convert to i2c's .probe_new()

On Tue, 6 Dec 2022 12:23:43 +0100
Uwe Kleine-König <[email protected]> wrote:

> Hello Jonathan,
>
> On Fri, Nov 18, 2022 at 11:37:46PM +0100, Uwe Kleine-König wrote:
> > drivers/iio/light/max44009.c | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
>
> all iio patches from my series but this one are applied in next now. I
> wonder what happend to that one, my best guess is that this patch was
> dropped by accident?

Ah. Oops. Applied now to the togreg branch of iio.git, but it won't
appear in next until around rc1 as I want to rebase that tree so
won't push it out as togreg (the in theory non rebasing branch)

For now pushed out as testing for 0-day etc to take a look at it.

Thanks,

Jonathan

>
> Best regards
> Uwe
>