Subject: [PATCH] docs: hwmon: Use file modes explicitly

As stated in the mainling list[1] and by checkpatch output, the file modes
for is_visible_func should be returned explicitly. Change that in the
documentation to avoid confusion.

[1]https://lore.kernel.org/linux-hwmon/[email protected]/

Signed-off-by: Joaquín Ignacio Aramendía <[email protected]>
---
Documentation/hwmon/hwmon-kernel-api.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/hwmon/hwmon-kernel-api.rst b/Documentation/hwmon/hwmon-kernel-api.rst
index f3276b3a381a..26cf55303c61 100644
--- a/Documentation/hwmon/hwmon-kernel-api.rst
+++ b/Documentation/hwmon/hwmon-kernel-api.rst
@@ -299,7 +299,7 @@ Parameters:

Return value:
The file mode for this attribute. Typically, this will be 0 (the
- attribute will not be created), S_IRUGO, or 'S_IRUGO | S_IWUSR'.
+ attribute will not be created), 0444, or 0644.

::

--
2.38.1


2022-12-28 16:26:53

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH] docs: hwmon: Use file modes explicitly

On Mon, Dec 12, 2022 at 11:12:46AM -0300, Joaqu?n Ignacio Aramend?a wrote:
> As stated in the mainling list[1] and by checkpatch output, the file modes
> for is_visible_func should be returned explicitly. Change that in the
> documentation to avoid confusion.
>
> [1]https://lore.kernel.org/linux-hwmon/[email protected]/
>
> Signed-off-by: Joaqu?n Ignacio Aramend?a <[email protected]>

Applied to hwmon-next.

Thanks,
Guenter

> ---
> Documentation/hwmon/hwmon-kernel-api.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/hwmon/hwmon-kernel-api.rst b/Documentation/hwmon/hwmon-kernel-api.rst
> index f3276b3a381a..26cf55303c61 100644
> --- a/Documentation/hwmon/hwmon-kernel-api.rst
> +++ b/Documentation/hwmon/hwmon-kernel-api.rst
> @@ -299,7 +299,7 @@ Parameters:
>
> Return value:
> The file mode for this attribute. Typically, this will be 0 (the
> - attribute will not be created), S_IRUGO, or 'S_IRUGO | S_IWUSR'.
> + attribute will not be created), 0444, or 0644.
>
> ::
>