2022-12-12 21:02:22

by Moises Cardona

[permalink] [raw]
Subject: [PATCH] Add HP Stream 8 to bytcr_rt5640.c

The HP Stream 8 tablet is identical to the HP Stream 7 in terms of the PCB,
with the exception of the added SIM Card Slot.
Therefore, I'm submitting this patch which properly initializes the audio
and enables the headphone jack to work, just like it does in the
HP Stream 7.

Signed-off-by: Moises Cardona <[email protected]>
---
sound/soc/intel/boards/bytcr_rt5640.c | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
index fb9d9e271845..1d964b1ceff4 100644
--- a/sound/soc/intel/boards/bytcr_rt5640.c
+++ b/sound/soc/intel/boards/bytcr_rt5640.c
@@ -796,6 +796,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
BYT_RT5640_SSP0_AIF1 |
BYT_RT5640_MCLK_EN),
},
+ { /* HP Stream 8 */
+ .matches = {
+ DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
+ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "HP Stream 8 Tablet"),
+ },
+ .driver_data = (void *)(BYTCR_INPUT_DEFAULTS |
+ BYT_RT5640_MONO_SPEAKER |
+ BYT_RT5640_JD_NOT_INV |
+ BYT_RT5640_SSP0_AIF1 |
+ BYT_RT5640_MCLK_EN),
+ },
{ /* I.T.Works TW891 */
.matches = {
DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
--
2.37.2


2022-12-13 12:54:30

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] Add HP Stream 8 to bytcr_rt5640.c

On Mon, Dec 12, 2022 at 03:58:35PM -0500, Moises Cardona wrote:
> The HP Stream 8 tablet is identical to the HP Stream 7 in terms of the PCB,
> with the exception of the added SIM Card Slot.
> Therefore, I'm submitting this patch which properly initializes the audio
> and enables the headphone jack to work, just like it does in the
> HP Stream 7.

As documented in submitting-patches.rst please send patches to the
maintainers for the code you would like to change. The normal kernel
workflow is that people apply patches from their inboxes, if they aren't
copied they are likely to not see the patch at all and it is much more
difficult to apply patches. You should include the maintainers for the
Intel drivers here.


Attachments:
(No filename) (740.00 B)
signature.asc (499.00 B)
Download all attachments