This series introduces dt-bindings documents for miscellaneous register
blocks implemented in Socionext UniPhier SoCs.
These are previously defined in the devicetree and used in the examples
of subnodes' dt-bindings, however, not documented.
These include two types of the blocks
* independent block including miscellaneous registers and functions for
the whole SoC (system controller and SoC-glue logic)
* sideband logic including control registers in the component (others)
And prior to adding these dt-bindings, fix examples in the existing
dt-bindings.
This series is part of the previous series shown below:
https://lore.kernel.org/linux-arm-kernel/[email protected]
Changes since v2:
- Drop redundant nodes in examples (clock, reset, soc-glue-debug)
- Drop parent node in examples
- Add more properties to examples for pinctrl
- Add a patch for regulator change
- Use consistent quotes
- Drop unit address patterns of patternProperties
- Mandatory unit address pattern for efuse (soc-glue-debug)
- Fix additionalProperties (ahci-glue)
Changes since v1:
- Fix examples in the existing dt-bindings (Add PATCH 1-7)
- Add dt-bindings for SoC-glue logic debug part (Add PATCH 10)
- Drop generic and ld6b compatible strings
- Change "usb-controller" node in soc-glue to "usb-hub"
- Change "usb-controller" node in USB glue layer example to "usb"
- Add negation of child properties by compatible string
Kunihiko Hayashi (17):
dt-bindings: clock: Fix node descriptions in uniphier-clock example
dt-bindings: reset: Fix node descriptions in uniphier-reset example
dt-bindings: pinctrl: Fix node descriptions in uniphier-pinctrl
example
dt-bindings: regulator: Fix node descriptions in uniphier-regulator
example
dt-bindings: watchdog: Fix node descriptions in uniphier-wdt example
dt-bindings: thermal: Fix node descriptions in uniphier-thermal
example
dt-bindings: phy: Fix node descriptions in uniphier-phy example
dt-bindings: nvmem: Fix node descriptions in uniphier-efuse example
dt-bindings: soc: socionext: Add UniPhier system controller
dt-bindings: soc: socionext: Add UniPhier SoC-glue logic
dt-bindings: soc: socionext: Add UniPhier SoC-glue logic debug part
dt-bindings: soc: socionext: Add UniPhier peripheral block
dt-bindings: soc: socionext: Add UniPhier media I/O block
dt-bindings: soc: socionext: Add UniPhier SD interface block
dt-bindings: soc: socionext: Add UniPhier ADAMV block
dt-bindings: soc: socionext: Add UniPhier DWC3 USB glue layer
dt-bindings: soc: socionext: Add UniPhier AHCI glue layer
.../clock/socionext,uniphier-clock.yaml | 39 +-----
.../nvmem/socionext,uniphier-efuse.yaml | 101 +++++++--------
.../phy/socionext,uniphier-ahci-phy.yaml | 24 ++--
.../phy/socionext,uniphier-usb2-phy.yaml | 41 +++----
.../phy/socionext,uniphier-usb3hs-phy.yaml | 29 ++---
.../phy/socionext,uniphier-usb3ss-phy.yaml | 26 ++--
.../pinctrl/socionext,uniphier-pinctrl.yaml | 17 ++-
.../socionext,uniphier-regulator.yaml | 21 ++--
.../reset/socionext,uniphier-glue-reset.yaml | 23 ++--
.../reset/socionext,uniphier-reset.yaml | 52 +-------
.../socionext/socionext,uniphier-adamv.yaml | 50 ++++++++
.../socionext,uniphier-ahci-glue.yaml | 77 ++++++++++++
.../socionext,uniphier-dwc3-glue.yaml | 106 ++++++++++++++++
.../socionext/socionext,uniphier-mioctrl.yaml | 65 ++++++++++
.../socionext,uniphier-perictrl.yaml | 64 ++++++++++
.../socionext/socionext,uniphier-sdctrl.yaml | 61 ++++++++++
.../socionext,uniphier-soc-glue-debug.yaml | 68 +++++++++++
.../socionext,uniphier-soc-glue.yaml | 115 ++++++++++++++++++
.../socionext/socionext,uniphier-sysctrl.yaml | 104 ++++++++++++++++
.../thermal/socionext,uniphier-thermal.yaml | 15 +--
.../watchdog/socionext,uniphier-wdt.yaml | 10 +-
MAINTAINERS | 1 +
22 files changed, 843 insertions(+), 266 deletions(-)
create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-adamv.yaml
create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml
create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml
create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-mioctrl.yaml
create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-perictrl.yaml
create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sdctrl.yaml
create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue-debug.yaml
create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml
--
2.25.1
Add devicetree binding schema for the peripheral block implemented on
Socionext Uniphier SoCs.
Peripheral block implemented on Socionext UniPhier SoCs is an integrated
component of the peripherals including UART, I2C/FI2C, and SCSSI.
Peripheral block has some function logics to control the component.
Signed-off-by: Kunihiko Hayashi <[email protected]>
---
.../socionext,uniphier-perictrl.yaml | 64 +++++++++++++++++++
1 file changed, 64 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-perictrl.yaml
diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-perictrl.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-perictrl.yaml
new file mode 100644
index 000000000000..0adcffe859ab
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-perictrl.yaml
@@ -0,0 +1,64 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/socionext/socionext,uniphier-perictrl.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Socionext UniPhier peripheral block controller
+
+maintainers:
+ - Kunihiko Hayashi <[email protected]>
+
+description: |+
+ Peripheral block implemented on Socionext UniPhier SoCs is an integrated
+ component of the peripherals including UART, I2C/FI2C, and SCSSI.
+ Peripheral block controller is a logic to control the component.
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - socionext,uniphier-ld4-perictrl
+ - socionext,uniphier-pro4-perictrl
+ - socionext,uniphier-pro5-perictrl
+ - socionext,uniphier-pxs2-perictrl
+ - socionext,uniphier-sld8-perictrl
+ - socionext,uniphier-ld11-perictrl
+ - socionext,uniphier-ld20-perictrl
+ - socionext,uniphier-pxs3-perictrl
+ - socionext,uniphier-nx1-perictrl
+ - const: simple-mfd
+ - const: syscon
+
+ reg:
+ maxItems: 1
+
+ clock-controller:
+ $ref: /schemas/clock/socionext,uniphier-clock.yaml#
+
+ reset-controller:
+ $ref: /schemas/reset/socionext,uniphier-reset.yaml#
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ syscon@59820000 {
+ compatible = "socionext,uniphier-ld20-perictrl",
+ "simple-mfd", "syscon";
+ reg = <0x59820000 0x200>;
+
+ clock-controller {
+ compatible = "socionext,uniphier-ld20-peri-clock";
+ #clock-cells = <1>;
+ };
+
+ reset-controller {
+ compatible = "socionext,uniphier-ld20-peri-reset";
+ #reset-cells = <1>;
+ };
+ };
--
2.25.1
Add devicetree binding schema for the ADAMV block implemented on Socionext
Uniphier SoCs.
The ADAMV block is analog signal amplifier that is a part of the external
video and audio I/O system. This block is implemented on LD11 and LD20,
and this is defined for controlling audio I/O reset only.
Signed-off-by: Kunihiko Hayashi <[email protected]>
---
.../socionext/socionext,uniphier-adamv.yaml | 50 +++++++++++++++++++
1 file changed, 50 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-adamv.yaml
diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-adamv.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-adamv.yaml
new file mode 100644
index 000000000000..32d9cc2d72a8
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-adamv.yaml
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/socionext/socionext,uniphier-adamv.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Socionext UniPhier ADAMV block
+
+maintainers:
+ - Kunihiko Hayashi <[email protected]>
+
+description: |+
+ ADAMV block implemented on Socionext UniPhier SoCs is an analog signal
+ amplifier that is a part of the external video and audio I/O system.
+
+ This block is defined for controlling audio I/O reset only.
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - socionext,uniphier-ld11-adamv
+ - socionext,uniphier-ld20-adamv
+ - const: simple-mfd
+ - const: syscon
+
+ reg:
+ maxItems: 1
+
+ reset-controller:
+ $ref: /schemas/reset/socionext,uniphier-reset.yaml#
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ syscon@57920000 {
+ compatible = "socionext,uniphier-ld20-adamv",
+ "simple-mfd", "syscon";
+ reg = <0x57920000 0x1000>;
+
+ reset-controller {
+ compatible = "socionext,uniphier-ld20-adamv-reset";
+ #reset-cells = <1>;
+ };
+ };
--
2.25.1
Prior to adding dt-bindings for SoC-dependent controllers, rename the
thermal node and its parent node to the generic names in the example.
And drop a parent node of the thermal-sensor as it is not directly
necessary.
Signed-off-by: Kunihiko Hayashi <[email protected]>
---
.../thermal/socionext,uniphier-thermal.yaml | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml b/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml
index c5b25ce44956..6f975821fa5e 100644
--- a/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml
@@ -46,14 +46,9 @@ examples:
- |
// The UniPhier thermal should be a subnode of a "syscon" compatible node.
- sysctrl@61840000 {
- compatible = "socionext,uniphier-ld20-sysctrl",
- "simple-mfd", "syscon";
- reg = <0x61840000 0x10000>;
-
- pvtctl: thermal {
- compatible = "socionext,uniphier-ld20-thermal";
- interrupts = <0 3 1>;
- #thermal-sensor-cells = <0>;
- };
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ pvtctl: thermal-sensor {
+ compatible = "socionext,uniphier-ld20-thermal";
+ interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
+ #thermal-sensor-cells = <0>;
};
--
2.25.1
Drop parent node of the pinctrl as it is not directly necessary, and
add more examples, that is "groups", "function", and a child node to set
pin attributes, to express this pinctrl node in detail.
Signed-off-by: Kunihiko Hayashi <[email protected]>
---
.../pinctrl/socionext,uniphier-pinctrl.yaml | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
index 14a8c0215cc6..bc34e2c872bc 100644
--- a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
@@ -1,4 +1,5 @@
# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+
%YAML 1.2
---
$id: http://devicetree.org/schemas/pinctrl/socionext,uniphier-pinctrl.yaml#
@@ -69,11 +70,17 @@ examples:
- |
// The UniPhier pinctrl should be a subnode of a "syscon" compatible node.
- soc-glue@5f800000 {
- compatible = "socionext,uniphier-pro4-soc-glue", "simple-mfd", "syscon";
- reg = <0x5f800000 0x2000>;
+ pinctrl {
+ compatible = "socionext,uniphier-ld20-pinctrl";
+
+ pinctrl_ether_rgmii: ether-rgmii {
+ groups = "ether_rgmii";
+ function = "ether_rgmii";
- pinctrl: pinctrl {
- compatible = "socionext,uniphier-pro4-pinctrl";
+ tx {
+ pins = "RGMII_TXCLK", "RGMII_TXD0", "RGMII_TXD1",
+ "RGMII_TXD2", "RGMII_TXD3", "RGMII_TXCTL";
+ drive-strength = <9>;
+ };
};
};
--
2.25.1
Add DT binding schema for components belonging to the platform-specific
DWC3 USB glue layer implemented in UniPhier SoCs.
This USB glue layer works as a sideband logic for the host controller,
including core reset, vbus control, PHYs, and some signals to the
controller.
Signed-off-by: Kunihiko Hayashi <[email protected]>
---
.../socionext,uniphier-dwc3-glue.yaml | 106 ++++++++++++++++++
1 file changed, 106 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml
diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml
new file mode 100644
index 000000000000..bd0def7236b5
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml
@@ -0,0 +1,106 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/socionext/socionext,uniphier-dwc3-glue.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Socionext UniPhier SoC DWC3 USB3.0 glue layer
+
+maintainers:
+ - Kunihiko Hayashi <[email protected]>
+
+description: |+
+ DWC3 USB3.0 glue layer implemented on Socionext UniPhier SoCs is
+ a sideband logic handling signals to DWC3 host controller inside
+ USB3.0 component.
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - socionext,uniphier-pro4-dwc3-glue
+ - socionext,uniphier-pro5-dwc3-glue
+ - socionext,uniphier-pxs2-dwc3-glue
+ - socionext,uniphier-ld20-dwc3-glue
+ - socionext,uniphier-pxs3-dwc3-glue
+ - socionext,uniphier-nx1-dwc3-glue
+ - const: simple-mfd
+
+ reg:
+ maxItems: 1
+
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 1
+
+ ranges: true
+
+patternProperties:
+ "^reset-controller@[0-9a-f]+$":
+ $ref: /schemas/reset/socionext,uniphier-glue-reset.yaml#
+
+ "^regulator@[0-9a-f]+$":
+ $ref: /schemas/regulator/socionext,uniphier-regulator.yaml#
+
+ "^phy@[0-9a-f]+$":
+ oneOf:
+ - $ref: /schemas/phy/socionext,uniphier-usb3hs-phy.yaml#
+ - $ref: /schemas/phy/socionext,uniphier-usb3ss-phy.yaml#
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ usb@65b00000 {
+ compatible = "socionext,uniphier-ld20-dwc3-glue", "simple-mfd";
+ reg = <0x65b00000 0x400>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0x65b00000 0x400>;
+
+ reset-controller@0 {
+ compatible = "socionext,uniphier-ld20-usb3-reset";
+ reg = <0x0 0x4>;
+ #reset-cells = <1>;
+ clock-names = "link";
+ clocks = <&sys_clk 14>;
+ reset-names = "link";
+ resets = <&sys_rst 14>;
+ };
+
+ regulator@100 {
+ compatible = "socionext,uniphier-ld20-usb3-regulator";
+ reg = <0x100 0x10>;
+ clock-names = "link";
+ clocks = <&sys_clk 14>;
+ reset-names = "link";
+ resets = <&sys_rst 14>;
+ };
+
+ phy@200 {
+ compatible = "socionext,uniphier-ld20-usb3-hsphy";
+ reg = <0x200 0x10>;
+ #phy-cells = <0>;
+ clock-names = "link", "phy";
+ clocks = <&sys_clk 14>, <&sys_clk 16>;
+ reset-names = "link", "phy";
+ resets = <&sys_rst 14>, <&sys_rst 16>;
+ };
+
+ phy@300 {
+ compatible = "socionext,uniphier-ld20-usb3-ssphy";
+ reg = <0x300 0x10>;
+ #phy-cells = <0>;
+ clock-names = "link", "phy";
+ clocks = <&sys_clk 14>, <&sys_clk 18>;
+ reset-names = "link", "phy";
+ resets = <&sys_rst 14>, <&sys_rst 18>;
+ };
+ };
+
--
2.25.1
Drop a parent node of the watchdog as it is not directly necessary.
Signed-off-by: Kunihiko Hayashi <[email protected]>
---
.../bindings/watchdog/socionext,uniphier-wdt.yaml | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/Documentation/devicetree/bindings/watchdog/socionext,uniphier-wdt.yaml b/Documentation/devicetree/bindings/watchdog/socionext,uniphier-wdt.yaml
index 90698cfa8f94..70c005fdd197 100644
--- a/Documentation/devicetree/bindings/watchdog/socionext,uniphier-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/socionext,uniphier-wdt.yaml
@@ -25,12 +25,6 @@ examples:
- |
// The UniPhier watchdog should be a subnode of a "syscon" compatible node.
- sysctrl@61840000 {
- compatible = "socionext,uniphier-ld11-sysctrl",
- "simple-mfd", "syscon";
- reg = <0x61840000 0x10000>;
-
- watchdog {
- compatible = "socionext,uniphier-wdt";
- };
+ watchdog {
+ compatible = "socionext,uniphier-wdt";
};
--
2.25.1
Add devicetree binding schema for the SoC-glue logic debug part
implemented on Socionext Uniphier SoCs.
This SoC-glue logic debug part is a set of miscellaneous function
registers handling signals for specific devices outside system
components, and also has multiple functions such as efuse, debug unit,
several monitors for specific SoC, and so on.
Signed-off-by: Kunihiko Hayashi <[email protected]>
---
.../socionext,uniphier-soc-glue-debug.yaml | 68 +++++++++++++++++++
1 file changed, 68 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue-debug.yaml
diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue-debug.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue-debug.yaml
new file mode 100644
index 000000000000..1341544d1df5
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue-debug.yaml
@@ -0,0 +1,68 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/socionext/socionext,uniphier-soc-glue-debug.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Socionext UniPhier SoC-glue logic debug part
+
+maintainers:
+ - Kunihiko Hayashi <[email protected]>
+
+description: |+
+ SoC-glue logic debug part implemented on Socionext UniPhier SoCs is
+ a collection of miscellaneous function registers handling signals outside
+ system components for debug and monitor use.
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - socionext,uniphier-ld4-soc-glue-debug
+ - socionext,uniphier-pro4-soc-glue-debug
+ - socionext,uniphier-pro5-soc-glue-debug
+ - socionext,uniphier-pxs2-soc-glue-debug
+ - socionext,uniphier-sld8-soc-glue-debug
+ - socionext,uniphier-ld11-soc-glue-debug
+ - socionext,uniphier-ld20-soc-glue-debug
+ - socionext,uniphier-pxs3-soc-glue-debug
+ - socionext,uniphier-nx1-soc-glue-debug
+ - const: simple-mfd
+ - const: syscon
+
+ reg:
+ maxItems: 1
+
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 1
+
+ ranges: true
+
+patternProperties:
+ "^efuse@[0-9a-f]+$":
+ $ref: /schemas/nvmem/socionext,uniphier-efuse.yaml#
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ syscon@5f900000 {
+ compatible = "socionext,uniphier-pxs2-soc-glue-debug",
+ "simple-mfd", "syscon";
+ reg = <0x5f900000 0x2000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0x5f900000 0x2000>;
+
+ efuse@100 {
+ compatible = "socionext,uniphier-efuse";
+ reg = <0x100 0x28>;
+ };
+ };
--
2.25.1
On 13/12/2022 09:24, Kunihiko Hayashi wrote:
> Prior to adding dt-bindings for SoC-dependent controllers, rename the
> thermal node and its parent node to the generic names in the example.
>
> And drop a parent node of the thermal-sensor as it is not directly
Drop double space in "thermal-sensor as" above
With this:
Acked-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
On 13/12/2022 09:24, Kunihiko Hayashi wrote:
> Drop parent node of the pinctrl as it is not directly necessary, and
> add more examples, that is "groups", "function", and a child node to set
> pin attributes, to express this pinctrl node in detail.
>
> Signed-off-by: Kunihiko Hayashi <[email protected]>
> ---
> .../pinctrl/socionext,uniphier-pinctrl.yaml | 17 ++++++++++++-----
> 1 file changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
> index 14a8c0215cc6..bc34e2c872bc 100644
> --- a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
> @@ -1,4 +1,5 @@
> # SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +
Drop this part, no blank lines between SPDX and YAML.
> %YAML 1.2
Best regards,
Krzysztof
On 13/12/2022 09:24, Kunihiko Hayashi wrote:
> Drop a parent node of the watchdog as it is not directly necessary.
>
> Signed-off-by: Kunihiko Hayashi <[email protected]>
> ---
> .../bindings/watchdog/socionext,uniphier-wdt.yaml | 10 ++--------
Acked-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
On 13/12/2022 09:24, Kunihiko Hayashi wrote:
> Add devicetree binding schema for the SoC-glue logic debug part
> implemented on Socionext Uniphier SoCs.
>
> This SoC-glue logic debug part is a set of miscellaneous function
> registers handling signals for specific devices outside system
> components, and also has multiple functions such as efuse, debug unit,
> several monitors for specific SoC, and so on.
>
> Signed-off-by: Kunihiko Hayashi <[email protected]>
> ---
Reviewed-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
On 13/12/2022 09:24, Kunihiko Hayashi wrote:
> Add DT binding schema for components belonging to the platform-specific
> DWC3 USB glue layer implemented in UniPhier SoCs.
>
> This USB glue layer works as a sideband logic for the host controller,
> including core reset, vbus control, PHYs, and some signals to the
> controller.
>
> Signed-off-by: Kunihiko Hayashi <[email protected]>
> ---
> .../socionext,uniphier-dwc3-glue.yaml | 106 ++++++++++++++++++
> 1 file changed, 106 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml
> new file mode 100644
> index 000000000000..bd0def7236b5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml
> @@ -0,0 +1,106 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
Reviewed-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
On 13/12/2022 09:24, Kunihiko Hayashi wrote:
> Add devicetree binding schema for the peripheral block implemented on
> Socionext Uniphier SoCs.
>
> Peripheral block implemented on Socionext UniPhier SoCs is an integrated
> component of the peripherals including UART, I2C/FI2C, and SCSSI.
>
> Peripheral block has some function logics to control the component.
>
> Signed-off-by: Kunihiko Hayashi <[email protected]>
> ---
Reviewed-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
On 13/12/2022 09:24, Kunihiko Hayashi wrote:
> Add devicetree binding schema for the ADAMV block implemented on Socionext
> Uniphier SoCs.
>
> The ADAMV block is analog signal amplifier that is a part of the external
> video and audio I/O system. This block is implemented on LD11 and LD20,
> and this is defined for controlling audio I/O reset only.
>
> Signed-off-by: Kunihiko Hayashi <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
On 2022/12/13 23:54, Krzysztof Kozlowski wrote:
> On 13/12/2022 09:24, Kunihiko Hayashi wrote:
>> Prior to adding dt-bindings for SoC-dependent controllers, rename the
>> thermal node and its parent node to the generic names in the example.
>>
>> And drop a parent node of the thermal-sensor as it is not directly
>
> Drop double space in "thermal-sensor as" above
I'll fix it.
> With this:
>
> Acked-by: Krzysztof Kozlowski <[email protected]>
Thank you,
---
Best Regards
Kunihiko Hayashi
On 2022/12/13 23:52, Krzysztof Kozlowski wrote:
> On 13/12/2022 09:24, Kunihiko Hayashi wrote:
>> Drop parent node of the pinctrl as it is not directly necessary, and
>> add more examples, that is "groups", "function", and a child node to set
>> pin attributes, to express this pinctrl node in detail.
>>
>> Signed-off-by: Kunihiko Hayashi <[email protected]>
>> ---
>> .../pinctrl/socionext,uniphier-pinctrl.yaml | 17 ++++++++++++-----
>> 1 file changed, 12 insertions(+), 5 deletions(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
>> b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
>> index 14a8c0215cc6..bc34e2c872bc 100644
>> ---
>> a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
>> +++
>> b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
>> @@ -1,4 +1,5 @@
>> # SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +
>
> Drop this part, no blank lines between SPDX and YAML.
Thank you for checking.
I carelessly added a blank line. I'll remove it.
Thank you,
---
Best Regards
Kunihiko Hayashi
On Tue, Dec 13, 2022 at 05:24:32PM +0900, Kunihiko Hayashi wrote:
> This series introduces dt-bindings documents for miscellaneous register
> blocks implemented in Socionext UniPhier SoCs.
>
> These are previously defined in the devicetree and used in the examples
> of subnodes' dt-bindings, however, not documented.
>
> These include two types of the blocks
>
> * independent block including miscellaneous registers and functions for
> the whole SoC (system controller and SoC-glue logic)
>
> * sideband logic including control registers in the component (others)
>
> And prior to adding these dt-bindings, fix examples in the existing
> dt-bindings.
>
> This series is part of the previous series shown below:
> https://lore.kernel.org/linux-arm-kernel/[email protected]
>
> Changes since v2:
> - Drop redundant nodes in examples (clock, reset, soc-glue-debug)
> - Drop parent node in examples
> - Add more properties to examples for pinctrl
> - Add a patch for regulator change
> - Use consistent quotes
> - Drop unit address patterns of patternProperties
> - Mandatory unit address pattern for efuse (soc-glue-debug)
> - Fix additionalProperties (ahci-glue)
>
> Changes since v1:
> - Fix examples in the existing dt-bindings (Add PATCH 1-7)
> - Add dt-bindings for SoC-glue logic debug part (Add PATCH 10)
> - Drop generic and ld6b compatible strings
> - Change "usb-controller" node in soc-glue to "usb-hub"
> - Change "usb-controller" node in USB glue layer example to "usb"
> - Add negation of child properties by compatible string
>
> Kunihiko Hayashi (17):
> dt-bindings: clock: Fix node descriptions in uniphier-clock example
> dt-bindings: reset: Fix node descriptions in uniphier-reset example
> dt-bindings: pinctrl: Fix node descriptions in uniphier-pinctrl
> example
> dt-bindings: regulator: Fix node descriptions in uniphier-regulator
> example
> dt-bindings: watchdog: Fix node descriptions in uniphier-wdt example
> dt-bindings: thermal: Fix node descriptions in uniphier-thermal
> example
> dt-bindings: phy: Fix node descriptions in uniphier-phy example
> dt-bindings: nvmem: Fix node descriptions in uniphier-efuse example
> dt-bindings: soc: socionext: Add UniPhier system controller
> dt-bindings: soc: socionext: Add UniPhier SoC-glue logic
> dt-bindings: soc: socionext: Add UniPhier SoC-glue logic debug part
> dt-bindings: soc: socionext: Add UniPhier peripheral block
> dt-bindings: soc: socionext: Add UniPhier media I/O block
> dt-bindings: soc: socionext: Add UniPhier SD interface block
> dt-bindings: soc: socionext: Add UniPhier ADAMV block
> dt-bindings: soc: socionext: Add UniPhier DWC3 USB glue layer
> dt-bindings: soc: socionext: Add UniPhier AHCI glue layer
You sent this To me, so I'm assuming you want me to apply it?
Otherwise, it can go via the Socionext tree. Let me know and I can fix
up Krzysztof's comments and apply the series.
Rob
Hi Rob,
On 2022/12/20 0:49, Rob Herring wrote:
> On Tue, Dec 13, 2022 at 05:24:32PM +0900, Kunihiko Hayashi wrote:
>> This series introduces dt-bindings documents for miscellaneous register
>> blocks implemented in Socionext UniPhier SoCs.
>>
>> These are previously defined in the devicetree and used in the examples
>> of subnodes' dt-bindings, however, not documented.
>>
>> These include two types of the blocks
>>
>> * independent block including miscellaneous registers and functions for
>> the whole SoC (system controller and SoC-glue logic)
>>
>> * sideband logic including control registers in the component (others)
>>
>> And prior to adding these dt-bindings, fix examples in the existing
>> dt-bindings.
>>
>> This series is part of the previous series shown below:
>>
> https://lore.kernel.org/linux-arm-kernel/20221107103410.3443-2-hayashi.kun
> [email protected]
>>
>> Changes since v2:
>> - Drop redundant nodes in examples (clock, reset, soc-glue-debug)
>> - Drop parent node in examples
>> - Add more properties to examples for pinctrl
>> - Add a patch for regulator change
>> - Use consistent quotes
>> - Drop unit address patterns of patternProperties
>> - Mandatory unit address pattern for efuse (soc-glue-debug)
>> - Fix additionalProperties (ahci-glue)
>>
>> Changes since v1:
>> - Fix examples in the existing dt-bindings (Add PATCH 1-7)
>> - Add dt-bindings for SoC-glue logic debug part (Add PATCH 10)
>> - Drop generic and ld6b compatible strings
>> - Change "usb-controller" node in soc-glue to "usb-hub"
>> - Change "usb-controller" node in USB glue layer example to "usb"
>> - Add negation of child properties by compatible string
>>
>> Kunihiko Hayashi (17):
>> dt-bindings: clock: Fix node descriptions in uniphier-clock example
>> dt-bindings: reset: Fix node descriptions in uniphier-reset example
>> dt-bindings: pinctrl: Fix node descriptions in uniphier-pinctrl
>> example
>> dt-bindings: regulator: Fix node descriptions in uniphier-regulator
>> example
>> dt-bindings: watchdog: Fix node descriptions in uniphier-wdt example
>> dt-bindings: thermal: Fix node descriptions in uniphier-thermal
>> example
>> dt-bindings: phy: Fix node descriptions in uniphier-phy example
>> dt-bindings: nvmem: Fix node descriptions in uniphier-efuse example
>> dt-bindings: soc: socionext: Add UniPhier system controller
>> dt-bindings: soc: socionext: Add UniPhier SoC-glue logic
>> dt-bindings: soc: socionext: Add UniPhier SoC-glue logic debug part
>> dt-bindings: soc: socionext: Add UniPhier peripheral block
>> dt-bindings: soc: socionext: Add UniPhier media I/O block
>> dt-bindings: soc: socionext: Add UniPhier SD interface block
>> dt-bindings: soc: socionext: Add UniPhier ADAMV block
>> dt-bindings: soc: socionext: Add UniPhier DWC3 USB glue layer
>> dt-bindings: soc: socionext: Add UniPhier AHCI glue layer
>
> You sent this To me, so I'm assuming you want me to apply it?
> Otherwise, it can go via the Socionext tree. Let me know and I can fix
> up Krzysztof's comments and apply the series.
Currently I don't have the Socionext tree for pull-request,
so I'd be happy if you could fix up the comments and apply the series.
Thank you,
---
Best Regards
Kunihiko Hayashi
Hi Rob,
On 2022/12/20 10:13, Kunihiko Hayashi wrote:
>> You sent this To me, so I'm assuming you want me to apply it?
>> Otherwise, it can go via the Socionext tree. Let me know and I can fix
>> up Krzysztof's comments and apply the series.
>
> Currently I don't have the Socionext tree for pull-request,
> so I'd be happy if you could fix up the comments and apply the series.
Could you please do the above?
Or should I submit the fixed v4 to [email protected] and request a merge of
this series?
After fixing the dt-bindings in this series, I'll continue to submit patch
series to update the devicetree.
Thank you,
---
Best Regards
Kunihiko Hayashi
On 2023/01/20 4:57, Rob Herring wrote:
> On Thu, Jan 19, 2023 at 2:22 AM Kunihiko Hayashi
> <[email protected]> wrote:
>>
>> Hi Rob,
>>
>> On 2022/12/20 10:13, Kunihiko Hayashi wrote:
>>
>>>> You sent this To me, so I'm assuming you want me to apply it?
>>>> Otherwise, it can go via the Socionext tree. Let me know and I can fix
>>>> up Krzysztof's comments and apply the series.
>>>
>>> Currently I don't have the Socionext tree for pull-request,
>>> so I'd be happy if you could fix up the comments and apply the series.
>> Could you please do the above?
>
> Yes, I've already applied this.
Thanks a lot for your help!
---
Best Regards
Kunihiko Hayashi
On Thu, Jan 19, 2023 at 2:22 AM Kunihiko Hayashi
<[email protected]> wrote:
>
> Hi Rob,
>
> On 2022/12/20 10:13, Kunihiko Hayashi wrote:
>
> >> You sent this To me, so I'm assuming you want me to apply it?
> >> Otherwise, it can go via the Socionext tree. Let me know and I can fix
> >> up Krzysztof's comments and apply the series.
> >
> > Currently I don't have the Socionext tree for pull-request,
> > so I'd be happy if you could fix up the comments and apply the series.
> Could you please do the above?
Yes, I've already applied this.
Rob