2022-12-14 11:48:04

by Christophe Branchereau

[permalink] [raw]
Subject: [PATCH v2 0/2] Add support for the AUO A030JTN01 TFT LCD

Changes since v1:
reworked the dt-bindings to add a spi node, dropped properties already
present in panel-common.yaml

Christophe Branchereau (1):
drm/panel: Add driver for the AUO A030JTN01 TFT LCD

Paul Cercueil (1):
dt-bindings: display/panel: Add AUO A030JTN01

.../bindings/display/panel/auo,a030jtn01.yaml | 61 ++++
drivers/gpu/drm/panel/Kconfig | 8 +
drivers/gpu/drm/panel/Makefile | 1 +
drivers/gpu/drm/panel/panel-auo-a030jtn01.c | 295 ++++++++++++++++++
4 files changed, 365 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/auo,a030jtn01.yaml
create mode 100644 drivers/gpu/drm/panel/panel-auo-a030jtn01.c

--
2.35.1


2022-12-14 11:48:09

by Christophe Branchereau

[permalink] [raw]
Subject: [PATCH v2 2/2] dt-bindings: display/panel: Add AUO A030JTN01

From: Paul Cercueil <[email protected]>

Add binding for the AUO A030JTN01 panel, which is a 320x480 3.0" 4:3
24-bit TFT LCD panel with non-square pixels and a delta-RGB 8-bit
interface.

Signed-off-by: Paul Cercueil <[email protected]>
Signed-off-by: Christophe Branchereau <[email protected]>
---
.../bindings/display/panel/auo,a030jtn01.yaml | 61 +++++++++++++++++++
1 file changed, 61 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/auo,a030jtn01.yaml

diff --git a/Documentation/devicetree/bindings/display/panel/auo,a030jtn01.yaml b/Documentation/devicetree/bindings/display/panel/auo,a030jtn01.yaml
new file mode 100644
index 000000000000..6c099eb63434
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/auo,a030jtn01.yaml
@@ -0,0 +1,61 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/auo,a030jtn01.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: AUO A030JTN01 3.0" (320x480 pixels) 24-bit TFT LCD panel
+
+description: |
+ The panel must obey the rules for a SPI slave device as specified in
+ spi/spi-controller.yaml
+
+maintainers:
+ - Paul Cercueil <[email protected]>
+ - Christophe Branchereau <[email protected]>
+
+allOf:
+ - $ref: panel-common.yaml#
+ - $ref: /schemas/spi/spi-peripheral-props.yaml#
+
+properties:
+ compatible:
+ const: auo,a030jtn01
+
+ reg:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - power-supply
+ - reset-gpios
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ spi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ panel@0 {
+ compatible = "auo,a030jtn01";
+ reg = <0>;
+
+ spi-max-frequency = <10000000>;
+
+ reset-gpios = <&gpe 4 GPIO_ACTIVE_LOW>;
+ power-supply = <&lcd_power>;
+
+ backlight = <&backlight>;
+
+ port {
+ panel_input: endpoint {
+ remote-endpoint = <&panel_output>;
+ };
+ };
+ };
+ };
--
2.35.1

2022-12-16 11:08:05

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] dt-bindings: display/panel: Add AUO A030JTN01

On 14/12/2022 12:41, Christophe Branchereau wrote:
> From: Paul Cercueil <[email protected]>
>
> Add binding for the AUO A030JTN01 panel, which is a 320x480 3.0" 4:3
> 24-bit TFT LCD panel with non-square pixels and a delta-RGB 8-bit
> interface.
>
> Signed-off-by: Paul Cercueil <[email protected]>
> Signed-off-by: Christophe Branchereau <[email protected]>
> ---
> .../bindings/display/panel/auo,a030jtn01.yaml | 61 +++++++++++++++++++
> 1 file changed, 61 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/auo,a030jtn01.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/auo,a030jtn01.yaml b/Documentation/devicetree/bindings/display/panel/auo,a030jtn01.yaml
> new file mode 100644
> index 000000000000..6c099eb63434
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/auo,a030jtn01.yaml
> @@ -0,0 +1,61 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/auo,a030jtn01.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AUO A030JTN01 3.0" (320x480 pixels) 24-bit TFT LCD panel
> +
> +description: |
> + The panel must obey the rules for a SPI slave device as specified in
> + spi/spi-controller.yaml

Drop such description - it's obvious from referencing the schema below.
No need to open-write it in each binding. OTOH, you could describe here
the hardware more.

With adjusted description:

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof