2022-12-14 04:02:00

by Owen Yang

Subject: [PATCH 1/2] dt-bindings: arm: qcom: Add zombie with NVMe

Add entries in the device tree binding for sc7280-zombie with NVMe.

Signed-off-by: Owen Yang <[email protected]>
---

Documentation/devicetree/bindings/arm/qcom.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 27063a045bd0..0f8fabcae907 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -679,6 +679,18 @@ properties:
- const: google,zombie-sku512
- const: qcom,sc7280

+ - description: Google Zombie with NVMe (newest rev)
+ items:
+ - const: google,zombie-sku2
+ - const: google,zombie-sku3
+ - const: google,zombie-sku515
+ - const: qcom,sc7280
+
+ - description: Google Zombie with LTE and NVMe (newest rev)
+ items:
+ - const: google,zombie-sku514
+ - const: qcom,sc7280
+
- items:
- enum:
- lenovo,flex-5g
--
2.17.1

2022-12-14 04:02:25

by Owen Yang

Subject: [PATCH 2/2] arm64: dts: qcom: sc7280: Add DT for sc7280-herobrine-zombie with NVMe

Add DT for sc7280-herobrine-zombie with NVMe

Signed-off-by: Owen Yang <[email protected]>
---

arch/arm64/boot/dts/qcom/Makefile | 2 ++
.../dts/qcom/sc7280-herobrine-nvme-sku.dtsi | 14 ++++++++++++++
.../qcom/sc7280-herobrine-zombie-nvme-lte.dts | 17 +++++++++++++++++
.../dts/qcom/sc7280-herobrine-zombie-nvme.dts | 17 +++++++++++++++++
.../boot/dts/qcom/sc7280-herobrine-zombie.dtsi | 10 ----------
5 files changed, 50 insertions(+), 10 deletions(-)
create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-nvme-sku.dtsi
create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-nvme-lte.dts
create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-nvme.dts

diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 3e79496292e7..5dcb3dd9718f 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -121,6 +121,8 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-villager-r1.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-villager-r1-lte.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-zombie.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-zombie-lte.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-zombie-nvme.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-zombie-nvme-lte.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7280-idp.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7280-idp2.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7280-crd-r3.dtb
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-nvme-sku.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-nvme-sku.dtsi
new file mode 100644
index 000000000000..1aed02297f44
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-nvme-sku.dtsi
@@ -0,0 +1,14 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Google Herobrine dts fragment for NVMe SKUs
+ *
+ * Copyright 2022 Google LLC.
+ */
+
+&pcie1 {
+ status = "okay";
+};
+
+&pcie1_phy {
+ status = "okay";
+};
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-nvme-lte.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-nvme-lte.dts
new file mode 100644
index 000000000000..e1fcacdccd51
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-nvme-lte.dts
@@ -0,0 +1,17 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Google Zombie board device tree source
+ *
+ * Copyright 2022 Google LLC.
+ */
+
+/dts-v1/;
+
+#include "sc7280-herobrine-zombie.dtsi"
+#include "sc7280-herobrine-lte-sku.dtsi"
+#include "sc7280-herobrine-nvme-sku.dtsi"
+
+/ {
+ model = "Google Zombie with LTE and NVMe";
+ compatible = "google,zombie-sku514", "qcom,sc7280";
+};
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-nvme.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-nvme.dts
new file mode 100644
index 000000000000..e3d52c560363
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-nvme.dts
@@ -0,0 +1,17 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Google Zombie board device tree source
+ *
+ * Copyright 2022 Google LLC.
+ */
+
+/dts-v1/;
+
+#include "sc7280-herobrine-zombie.dtsi"
+#include "sc7280-herobrine-wifi-sku.dtsi"
+#include "sc7280-herobrine-nvme-sku.dtsi"
+
+/ {
+ model = "Google Zombie with NVMe";
+ compatible = "google,zombie-sku2","google,zombie-sku3","google,zombie-sku515", "qcom,sc7280";
+};
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dtsi
index 7fc0b6bfc0d6..4c49d14cca47 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dtsi
@@ -60,16 +60,6 @@ ap_tp_i2c: &i2c0 {
status = "okay";
};

-/* For nvme */
-&pcie1 {
- status = "okay";
-};
-
-/* For nvme */
-&pcie1_phy {
- status = "okay";
-};
-
&pm8350c_pwm_backlight{
/* Set the PWM period to 200 microseconds (5kHz duty cycle) */
pwms = <&pm8350c_pwm 3 200000>;
--
2.17.1

2022-12-14 09:12:02

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom: Add zombie with NVMe

On 14/12/2022 04:47, Owen Yang wrote:
> Add entries in the device tree binding for sc7280-zombie with NVMe.
>
> Signed-off-by: Owen Yang <[email protected]>
> ---
>
> Documentation/devicetree/bindings/arm/qcom.yaml | 12 ++++++++++++


Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2022-12-14 21:26:07

by Doug Anderson

Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom: Add zombie with NVMe

Hi,

On Tue, Dec 13, 2022 at 7:48 PM Owen Yang <[email protected]> wrote:
>
> Add entries in the device tree binding for sc7280-zombie with NVMe.
>
> Signed-off-by: Owen Yang <[email protected]>
> ---
>
> Documentation/devicetree/bindings/arm/qcom.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)

Reviewed-by: Douglas Anderson <[email protected]>

2022-12-14 21:26:27

by Doug Anderson

Subject: Re: [PATCH 2/2] arm64: dts: qcom: sc7280: Add DT for sc7280-herobrine-zombie with NVMe

Hi,

On Tue, Dec 13, 2022 at 7:48 PM Owen Yang <[email protected]> wrote:
>
> Add DT for sc7280-herobrine-zombie with NVMe
>
> Signed-off-by: Owen Yang <[email protected]>
> ---
>
> arch/arm64/boot/dts/qcom/Makefile | 2 ++
> .../dts/qcom/sc7280-herobrine-nvme-sku.dtsi | 14 ++++++++++++++
> .../qcom/sc7280-herobrine-zombie-nvme-lte.dts | 17 +++++++++++++++++
> .../dts/qcom/sc7280-herobrine-zombie-nvme.dts | 17 +++++++++++++++++
> .../boot/dts/qcom/sc7280-herobrine-zombie.dtsi | 10 ----------
> 5 files changed, 50 insertions(+), 10 deletions(-)
> create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-nvme-sku.dtsi
> create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-nvme-lte.dts
> create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-nvme.dts

It's like sunshine on a cloudy day!

Reviewed-by: Douglas Anderson <[email protected]>

2023-01-11 05:41:50

by Bjorn Andersson

Subject: Re: (subset) [PATCH 1/2] dt-bindings: arm: qcom: Add zombie with NVMe

On Wed, 14 Dec 2022 11:47:48 +0800, Owen Yang wrote:
> Add entries in the device tree binding for sc7280-zombie with NVMe.
>
>

Applied, thanks!

[2/2] arm64: dts: qcom: sc7280: Add DT for sc7280-herobrine-zombie with NVMe
commit: f6df873315f921581e430f731c430d1d6d234234

Best regards,
--
Bjorn Andersson <[email protected]>