2022-12-14 13:01:02

by Lukasz Majewski

Subject: [PATCH 1/4] ASoC: wm8940: Remove warning when no plat data present

The lack of platform data in the contemporary Linux
shall not be the reason to display warnings to the
kernel logs.

Signed-off-by: Lukasz Majewski <[email protected]>
---
sound/soc/codecs/wm8940.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/sound/soc/codecs/wm8940.c b/sound/soc/codecs/wm8940.c
index 8dac9fd88547..0b59020d747f 100644
--- a/sound/soc/codecs/wm8940.c
+++ b/sound/soc/codecs/wm8940.c
@@ -709,9 +709,7 @@ static int wm8940_probe(struct snd_soc_component *component)
if (ret < 0)
return ret;

- if (!pdata)
- dev_warn(component->dev, "No platform data supplied\n");
- else {
+ if (pdata) {
reg = snd_soc_component_read(component, WM8940_OUTPUTCTL);
ret = snd_soc_component_write(component, WM8940_OUTPUTCTL, reg | pdata->vroi);
if (ret < 0)
--
2.20.1

2022-12-14 13:20:44

by Charles Keepax

Subject: Re: [PATCH 1/4] ASoC: wm8940: Remove warning when no plat data present

On Wed, Dec 14, 2022 at 01:37:40PM +0100, Lukasz Majewski wrote:
> The lack of platform data in the contemporary Linux
> shall not be the reason to display warnings to the
> kernel logs.
>
> Signed-off-by: Lukasz Majewski <[email protected]>
> ---

Acked-by: Charles Keepax <[email protected]>

Thanks,
Charles