2022-12-15 07:42:19

by Miaoqian Lin

[permalink] [raw]
Subject: [PATCH] backlight: backlight: Fix doc for backlight_device_get_by_name

backlight_put() has been dropped, we should call put_device() to drop
the reference taken by backlight_device_get_by_name().

Fixes: 0f6a3256fd81 ("backlight: backlight: Drop backlight_put()")
Signed-off-by: Miaoqian Lin <[email protected]>
---
drivers/video/backlight/backlight.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c
index b788ff3d0f45..6eea72aa8dbf 100644
--- a/drivers/video/backlight/backlight.c
+++ b/drivers/video/backlight/backlight.c
@@ -501,7 +501,7 @@ EXPORT_SYMBOL(backlight_device_get_by_type);
*
* This function looks up a backlight device by its name. It obtains a reference
* on the backlight device and it is the caller's responsibility to drop the
- * reference by calling backlight_put().
+ * reference by calling put_device().
*
* Returns:
* A pointer to the backlight device if found, otherwise NULL.
--
2.25.1


2022-12-15 10:28:29

by Daniel Thompson

[permalink] [raw]
Subject: Re: [PATCH] backlight: backlight: Fix doc for backlight_device_get_by_name

On Thu, Dec 15, 2022 at 11:19:01AM +0400, Miaoqian Lin wrote:
> backlight_put() has been dropped, we should call put_device() to drop
> the reference taken by backlight_device_get_by_name().
>
> Fixes: 0f6a3256fd81 ("backlight: backlight: Drop backlight_put()")
> Signed-off-by: Miaoqian Lin <[email protected]>

Reviewed-by: Daniel Thompson <[email protected]>


Daniel.

2023-01-04 17:21:00

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH] backlight: backlight: Fix doc for backlight_device_get_by_name

On Thu, 15 Dec 2022, Miaoqian Lin wrote:

> backlight_put() has been dropped, we should call put_device() to drop
> the reference taken by backlight_device_get_by_name().
>
> Fixes: 0f6a3256fd81 ("backlight: backlight: Drop backlight_put()")
> Signed-off-by: Miaoqian Lin <[email protected]>
> ---
> drivers/video/backlight/backlight.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

--
Lee Jones [李琼斯]