2022-12-16 10:42:51

by Miaoqian Lin

[permalink] [raw]
Subject: [PATCH] memblock: Fix doc for memblock_phys_free

memblock_phys_free() is the counterpart to memblock_phys_alloc.
Change memblock_alloc_xx() with memblock_phys_alloc_xx() to keep
a consistency.

Signed-off-by: Miaoqian Lin <[email protected]>
---
mm/memblock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/memblock.c b/mm/memblock.c
index 511d4783dcf1..d036c7861310 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -836,7 +836,7 @@ void __init_memblock memblock_free(void *ptr, size_t size)
* @base: phys starting address of the boot memory block
* @size: size of the boot memory block in bytes
*
- * Free boot memory block previously allocated by memblock_alloc_xx() API.
+ * Free boot memory block previously allocated by memblock_phys_alloc_xx() API.
* The freeing memory will not be released to the buddy allocator.
*/
int __init_memblock memblock_phys_free(phys_addr_t base, phys_addr_t size)
--
2.25.1


2023-01-04 10:46:57

by Mike Rapoport

[permalink] [raw]
Subject: Re: [PATCH] memblock: Fix doc for memblock_phys_free

On Fri, Dec 16, 2022 at 02:03:03PM +0400, Miaoqian Lin wrote:
> memblock_phys_free() is the counterpart to memblock_phys_alloc.
> Change memblock_alloc_xx() with memblock_phys_alloc_xx() to keep
> a consistency.
>
> Signed-off-by: Miaoqian Lin <[email protected]>
> ---
> mm/memblock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memblock.c b/mm/memblock.c
> index 511d4783dcf1..d036c7861310 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -836,7 +836,7 @@ void __init_memblock memblock_free(void *ptr, size_t size)
> * @base: phys starting address of the boot memory block
> * @size: size of the boot memory block in bytes
> *
> - * Free boot memory block previously allocated by memblock_alloc_xx() API.
> + * Free boot memory block previously allocated by memblock_phys_alloc_xx() API.
> * The freeing memory will not be released to the buddy allocator.
> */
> int __init_memblock memblock_phys_free(phys_addr_t base, phys_addr_t size)
> --
> 2.25.1

Applied, thanks!

--
Sincerely yours,
Mike.