2022-12-17 14:43:47

by Miaoqian Lin

Subject: [PATCH] media: mc: entity: Fix doc for media_graph_walk_init

There is no media_graph_walk_free(). media_graph_walk_cleanup() is used
to release the resources.

Signed-off-by: Miaoqian Lin <[email protected]>
---
drivers/media/mc/mc-entity.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c
index b8bcbc734eaf..de25de328fbe 100644
--- a/drivers/media/mc/mc-entity.c
+++ b/drivers/media/mc/mc-entity.c
@@ -295,7 +295,7 @@ static struct media_entity *stack_pop(struct media_graph *graph)
*
* Reserve resources for graph walk in media device's current
* state. The memory must be released using
- * media_graph_walk_free().
+ * media_graph_walk_cleanup().
*
* Returns error on failure, zero on success.
*/
--
2.25.1

2022-12-18 14:29:21

by Laurent Pinchart

Subject: Re: [PATCH] media: mc: entity: Fix doc for media_graph_walk_init

Hi Miaoqian,

Thank you for the patch.

On Sat, Dec 17, 2022 at 06:31:13PM +0400, Miaoqian Lin wrote:
> There is no media_graph_walk_free(). media_graph_walk_cleanup() is used
> to release the resources.
>
> Signed-off-by: Miaoqian Lin <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> drivers/media/mc/mc-entity.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c
> index b8bcbc734eaf..de25de328fbe 100644
> --- a/drivers/media/mc/mc-entity.c
> +++ b/drivers/media/mc/mc-entity.c
> @@ -295,7 +295,7 @@ static struct media_entity *stack_pop(struct media_graph *graph)
> *
> * Reserve resources for graph walk in media device's current
> * state. The memory must be released using
> - * media_graph_walk_free().
> + * media_graph_walk_cleanup().
> *
> * Returns error on failure, zero on success.
> */

--
Regards,

Laurent Pinchart