2022-12-17 00:03:57

by Eric Chanudet

Subject: [PATCH v3 1/4] arm64: dts: qcom: rename pm8450a dtsi to sa8540p-pmics

pm8450a.dtsi was introduced for the descriptions of sa8540p based boards.
Rename the dtsi to make this relationship explicit.

Signed-off-by: Eric Chanudet <[email protected]>
---
arch/arm64/boot/dts/qcom/{pm8450a.dtsi => sa8540p-pmics.dtsi} | 0
arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 2 +-
2 files changed, 1 insertion(+), 1 deletion(-)
rename arch/arm64/boot/dts/qcom/{pm8450a.dtsi => sa8540p-pmics.dtsi} (100%)

diff --git a/arch/arm64/boot/dts/qcom/pm8450a.dtsi b/arch/arm64/boot/dts/qcom/sa8540p-pmics.dtsi
similarity index 100%
rename from arch/arm64/boot/dts/qcom/pm8450a.dtsi
rename to arch/arm64/boot/dts/qcom/sa8540p-pmics.dtsi
diff --git a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
index 6c547f1b13dc..77d499702ea8 100644
--- a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
+++ b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
@@ -10,7 +10,7 @@
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>

#include "sa8540p.dtsi"
-#include "pm8450a.dtsi"
+#include "sa8540p-pmics.dtsi"

/ {
model = "Qualcomm SA8540P Ride";
--
2.38.1

2022-12-17 14:59:48

by Konrad Dybcio

Subject: Re: [PATCH v3 1/4] arm64: dts: qcom: rename pm8450a dtsi to sa8540p-pmics

On 17.12.2022 00:26, Eric Chanudet wrote:
> pm8450a.dtsi was introduced for the descriptions of sa8540p based boards.
> Rename the dtsi to make this relationship explicit.
>
For the descriptions of PMICs used on SA8540p based boards, I suppose?
> Signed-off-by: Eric Chanudet <[email protected]>
> ---
The change itself looks perfectly fine though!

Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/{pm8450a.dtsi => sa8540p-pmics.dtsi} | 0
> arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 2 +-
> 2 files changed, 1 insertion(+), 1 deletion(-)
> rename arch/arm64/boot/dts/qcom/{pm8450a.dtsi => sa8540p-pmics.dtsi} (100%)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8450a.dtsi b/arch/arm64/boot/dts/qcom/sa8540p-pmics.dtsi
> similarity index 100%
> rename from arch/arm64/boot/dts/qcom/pm8450a.dtsi
> rename to arch/arm64/boot/dts/qcom/sa8540p-pmics.dtsi
> diff --git a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
> index 6c547f1b13dc..77d499702ea8 100644
> --- a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
> @@ -10,7 +10,7 @@
> #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>
> #include "sa8540p.dtsi"
> -#include "pm8450a.dtsi"
> +#include "sa8540p-pmics.dtsi"
>
> / {
> model = "Qualcomm SA8540P Ride";

2022-12-19 19:53:08

by Eric Chanudet

Subject: Re: [PATCH v3 1/4] arm64: dts: qcom: rename pm8450a dtsi to sa8540p-pmics

On Sat, Dec 17, 2022 at 03:36:58PM +0100, Konrad Dybcio wrote:
> On 17.12.2022 00:26, Eric Chanudet wrote:
> > pm8450a.dtsi was introduced for the descriptions of sa8540p based boards.
> > Rename the dtsi to make this relationship explicit.
> >
> For the descriptions of PMICs used on SA8540p based boards, I suppose?

Absolutely, thanks! Amended in v4:
https://lore.kernel.org/linux-arm-msm/[email protected]

--
Eric Chanudet