2022-12-21 07:34:46

by Judy Hsiao

Subject: [PATCH] arm64: dts: qcom: sc7280: add display port audio

Add DisplayPort sound node and lpass_cpu node
in sc7280-herobrine-audio-rt5682.dtsi.

Signed-off-by: Judy Hsiao <[email protected]>

--
---

.../qcom/sc7280-herobrine-audio-rt5682.dtsi | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
index af685bc35e10..69e7aa7b2f6c 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
@@ -33,9 +33,22 @@ codec {
};

dai-link@1 {
- link-name = "ALC5682";
+ link-name = "DisplayPort";
reg = <1>;

+ cpu {
+ sound-dai = <&lpass_cpu LPASS_DP_RX>;
+ };
+
+ codec {
+ sound-dai = <&mdss_dp>;
+ };
+ };
+
+ dai-link@2 {
+ link-name = "ALC5682";
+ reg = <2>;
+
cpu {
sound-dai = <&lpass_cpu MI2S_PRIMARY>;
};
@@ -92,6 +105,10 @@ dai-link@1 {
reg = <MI2S_SECONDARY>;
qcom,playback-sd-lines = <0>;
};
+
+ dai-link@5 {
+ reg = <LPASS_DP_RX>;
+ };
};

/* PINCTRL - ADDITIONS TO NODES IN PARENT DEVICE TREE FILES */
--
2.39.0.314.g84b9a713c41-goog

2022-12-21 08:36:07

by Krzysztof Kozlowski

Subject: Re: [PATCH] arm64: dts: qcom: sc7280: add display port audio

On 21/12/2022 08:17, Judy Hsiao wrote:
> Add DisplayPort sound node and lpass_cpu node
> in sc7280-herobrine-audio-rt5682.dtsi.
>
> Signed-off-by: Judy Hsiao <[email protected]>
>
> --
> ---

That's not a correct patch format. Apply it, git show and you will see
the error.

>
> .../qcom/sc7280-herobrine-audio-rt5682.dtsi | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> index af685bc35e10..69e7aa7b2f6c 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> @@ -33,9 +33,22 @@ codec {
> };
>
> dai-link@1 {
> - link-name = "ALC5682";
> + link-name = "DisplayPort";

Why do you change link@1 from DP to ALC?

Best regards,
Krzysztof

2023-01-13 01:35:38

by Judy Hsiao

Subject: Re: [PATCH] arm64: dts: qcom: sc7280: add display port audio

> Why do you change link@1 from DP to ALC?
Because I want make the order to be consistent with the 3 mic version. Thanks!
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682-3mic.dtsi
>
> Best regards,
> Krzysztof
>

2023-01-13 08:04:08

by Krzysztof Kozlowski

Subject: Re: [PATCH] arm64: dts: qcom: sc7280: add display port audio

On 13/01/2023 02:24, Judy Hsiao wrote:
>> Why do you change link@1 from DP to ALC?
> Because I want make the order to be consistent with the 3 mic version. Thanks!
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682-3mic.dtsi

You cut entire context. I don't know what is this about.

Best regards,
Krzysztof

2023-01-13 08:16:08

by Dmitry Baryshkov

Subject: Re: [PATCH] arm64: dts: qcom: sc7280: add display port audio

On 13/01/2023 03:24, Judy Hsiao wrote:
>> Why do you change link@1 from DP to ALC?
> Because I want make the order to be consistent with the 3 mic version. Thanks!
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682-3mic.dtsi

This should be explained in the commit message. And as Krzysztof wrote,
it should be explained, rather than mentioning some other platform.

>>
>> Best regards,
>> Krzysztof
>>

--
With best wishes
Dmitry