2022-12-21 13:35:01

by Jianhua Lu

[permalink] [raw]
Subject: [RESEND] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

Add Kinetic KTZ8866 backlight binding documentation.

Signed-off-by: Jianhua Lu <[email protected]>
---
.../leds/backlight/kinetic,ktz8866.yaml | 36 +++++++++++++++++++
1 file changed, 36 insertions(+)
create mode 100644 Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml

diff --git a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
new file mode 100644
index 000000000000..c63c21bf69d6
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
@@ -0,0 +1,36 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/backlight/kinetic,ktz8866.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Kinetic Technologies KTZ8866 backlight
+
+maintainers:
+ - Jianhua Lu <[email protected]>
+
+description: |
+ The Kinetic Technologies KTZ8866 is a high efficiency 6-sinks led backlight
+ with dual lcd bias power.
+ https://www.kinet-ic.com/ktz8866/
+
+allOf:
+ - $ref: common.yaml#
+
+properties:
+ compatible:
+ const: kinetic,ktz8866
+
+required:
+ - compatible
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ backlight {
+ compatible = "kinetic,ktz8866";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&bl_en_default>;
+ };
--
2.38.2


2022-12-21 15:35:12

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [RESEND] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

On 21/12/2022 14:24, Jianhua Lu wrote:
> Add Kinetic KTZ8866 backlight binding documentation.
>
> Signed-off-by: Jianhua Lu <[email protected]>

Do not resend. You need to fix everything, test and send a new patchset
(entire) with the changelog.

Best regards,
Krzysztof

2022-12-21 15:36:39

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [RESEND] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

On 21/12/2022 16:15, Jianhua Lu wrote:
> On Wed, Dec 21, 2022 at 04:03:44PM +0100, Krzysztof Kozlowski wrote:
>> On 21/12/2022 14:24, Jianhua Lu wrote:
>>> Add Kinetic KTZ8866 backlight binding documentation.
>>>
>>> Signed-off-by: Jianhua Lu <[email protected]>
>>
>> Do not resend. You need to fix everything, test and send a new patchset
>> (entire) with the changelog.
>
> Ok, I got it. I was just a bit confused about "Need to resend with proper
> thread".

But you did not thread it properly anyway.

Best regards,
Krzysztof

2022-12-21 15:38:41

by Jianhua Lu

[permalink] [raw]
Subject: Re: [RESEND] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

On Wed, Dec 21, 2022 at 04:03:44PM +0100, Krzysztof Kozlowski wrote:
> On 21/12/2022 14:24, Jianhua Lu wrote:
> > Add Kinetic KTZ8866 backlight binding documentation.
> >
> > Signed-off-by: Jianhua Lu <[email protected]>
>
> Do not resend. You need to fix everything, test and send a new patchset
> (entire) with the changelog.

Ok, I got it. I was just a bit confused about "Need to resend with proper
thread".
>
> Best regards,
> Krzysztof
>