2022-12-23 03:47:48

by Peng Fan (OSS)

[permalink] [raw]

Subject: [PATCH] arm64: dts: imx8mm-evk: update leds node

---

From: Peng Fan <[email protected]>

Drop deprecated label property, update node name as leds-gpio.yaml

Signed-off-by: Peng Fan <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
index e0b604ac0da4..0f87991dcb57 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
@@ -24,8 +24,7 @@ leds {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_gpio_led>;

- status {
- label = "status";
+ led-0 {
gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>;
default-state = "on";
};
--
2.37.1

2022-12-23 09:10:02

by Marco Felsch

[permalink] [raw]

Subject: Re: [PATCH] arm64: dts: imx8mm-evk: update leds node

---

Hi Peng,

On 22-12-23, Peng Fan (OSS) wrote:
> From: Peng Fan <[email protected]>
>
> Drop deprecated label property, update node name as leds-gpio.yaml
>
> Signed-off-by: Peng Fan <[email protected]>
> ---
> arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> index e0b604ac0da4..0f87991dcb57 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> @@ -24,8 +24,7 @@ leds {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_gpio_led>;
>
> - status {
> - label = "status";
> + led-0 {

We can use just 'led' since this is a single led.

Regards,
Marco

> gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>;
> default-state = "on";
> };
> --
> 2.37.1
>
>
>

2022-12-27 22:39:57

by Pavel Machek

[permalink] [raw]

Subject: Re: [PATCH] arm64: dts: imx8mm-evk: update leds node

---

On Fri 2022-12-23 11:02:27, Peng Fan (OSS) wrote:
> From: Peng Fan <[email protected]>
>
> Drop deprecated label property, update node name as leds-gpio.yaml
>
> Signed-off-by: Peng Fan <[email protected]>
> ---
> arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> index e0b604ac0da4..0f87991dcb57 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> @@ -24,8 +24,7 @@ leds {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_gpio_led>;
>
> - status {
> - label = "status";
> + led-0 {
> gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>;
> default-state = "on";
> };

Please cc led lists on led changes.

And don't do this, this will change userland interface.
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.

---

Attachments:

(No filename) (1.00 kB)
signature.asc (201.00 B)
Download all attachments