2022-12-23 09:27:54

by Li zeming

Subject: [PATCH] xfs: xfs_qm: remove unnecessary ‘0’ values from error

error is assigned first, so it does not need to initialize the
assignment.

Signed-off-by: Li zeming <[email protected]>
---
fs/xfs/xfs_qm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c
index ff53d40a2dae..e2c542f6dcd4 100644
--- a/fs/xfs/xfs_qm.c
+++ b/fs/xfs/xfs_qm.c
@@ -68,7 +68,7 @@ xfs_qm_dquot_walk(

while (1) {
struct xfs_dquot *batch[XFS_DQ_LOOKUP_BATCH];
- int error = 0;
+ int error;
int i;

mutex_lock(&qi->qi_tree_lock);
--
2.18.2

2023-01-03 18:29:24

by Darrick J. Wong

Subject: Re: [PATCH] xfs: xfs_qm: remove unnecessary ‘0’ values from error

On Fri, Dec 23, 2022 at 04:11:14PM +0800, Li zeming wrote:
> error is assigned first, so it does not need to initialize the
> assignment.
>
> Signed-off-by: Li zeming <[email protected]>

Looks fine to me...
Reviewed-by: Darrick J. Wong <[email protected]>

--D

> ---
> fs/xfs/xfs_qm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c
> index ff53d40a2dae..e2c542f6dcd4 100644
> --- a/fs/xfs/xfs_qm.c
> +++ b/fs/xfs/xfs_qm.c
> @@ -68,7 +68,7 @@ xfs_qm_dquot_walk(
>
> while (1) {
> struct xfs_dquot *batch[XFS_DQ_LOOKUP_BATCH];
> - int error = 0;
> + int error;
> int i;
>
> mutex_lock(&qi->qi_tree_lock);
> --
> 2.18.2
>