2022-12-23 11:46:19

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH] dt-bindings: clock: qcom,spmi-clkdiv: convert to DT schema

Convert Qualcomm SPMI PMIC clock divider bindings to DT schema.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/clock/qcom,spmi-clkdiv.txt | 59 ---------------
.../bindings/clock/qcom,spmi-clkdiv.yaml | 71 +++++++++++++++++++
2 files changed, 71 insertions(+), 59 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/clock/qcom,spmi-clkdiv.txt
create mode 100644 Documentation/devicetree/bindings/clock/qcom,spmi-clkdiv.yaml

diff --git a/Documentation/devicetree/bindings/clock/qcom,spmi-clkdiv.txt b/Documentation/devicetree/bindings/clock/qcom,spmi-clkdiv.txt
deleted file mode 100644
index 7474aba36607..000000000000
--- a/Documentation/devicetree/bindings/clock/qcom,spmi-clkdiv.txt
+++ /dev/null
@@ -1,59 +0,0 @@
-Qualcomm Technologies, Inc. SPMI PMIC clock divider (clkdiv)
-
-clkdiv configures the clock frequency of a set of outputs on the PMIC.
-These clocks are typically wired through alternate functions on
-gpio pins.
-
-=======================
-Properties
-=======================
-
-- compatible
- Usage: required
- Value type: <string>
- Definition: must be "qcom,spmi-clkdiv".
-
-- reg
- Usage: required
- Value type: <prop-encoded-array>
- Definition: base address of CLKDIV peripherals.
-
-- qcom,num-clkdivs
- Usage: required
- Value type: <u32>
- Definition: number of CLKDIV peripherals.
-
-- clocks:
- Usage: required
- Value type: <prop-encoded-array>
- Definition: reference to the xo clock.
-
-- clock-names:
- Usage: required
- Value type: <stringlist>
- Definition: must be "xo".
-
-- #clock-cells:
- Usage: required
- Value type: <u32>
- Definition: shall contain 1.
-
-=======
-Example
-=======
-
-pm8998_clk_divs: clock-controller@5b00 {
- compatible = "qcom,spmi-clkdiv";
- reg = <0x5b00>;
- #clock-cells = <1>;
- qcom,num-clkdivs = <3>;
- clocks = <&xo_board>;
- clock-names = "xo";
-
- assigned-clocks = <&pm8998_clk_divs 1>,
- <&pm8998_clk_divs 2>,
- <&pm8998_clk_divs 3>;
- assigned-clock-rates = <9600000>,
- <9600000>,
- <9600000>;
-};
diff --git a/Documentation/devicetree/bindings/clock/qcom,spmi-clkdiv.yaml b/Documentation/devicetree/bindings/clock/qcom,spmi-clkdiv.yaml
new file mode 100644
index 000000000000..16c95ad6c9d1
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/qcom,spmi-clkdiv.yaml
@@ -0,0 +1,71 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/clock/qcom,spmi-clkdiv.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm SPMI PMIC clock divider
+
+maintainers:
+ - Bjorn Andersson <[email protected]>
+ - Stephen Boyd <[email protected]>
+
+description: |
+ Qualcomm SPMI PMIC clock divider configures the clock frequency of a set of
+ outputs on the PMIC. These clocks are typically wired through alternate
+ functions on GPIO pins.
+
+properties:
+ compatible:
+ const: qcom,spmi-clkdiv
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ items:
+ - description: Board XO source
+
+ clock-names:
+ items:
+ - const: xo
+
+ "#clock-cells":
+ const: 1
+
+ qcom,num-clkdivs:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: Number of CLKDIV peripherals.
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - clock-names
+ - "#clock-cells"
+ - qcom,num-clkdivs
+
+additionalProperties: false
+
+examples:
+ - |
+ pmic {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ clock-controller@5b00 {
+ compatible = "qcom,spmi-clkdiv";
+ reg = <0x5b00>;
+ clocks = <&xo_board>;
+ clock-names = "xo";
+ #clock-cells = <1>;
+ qcom,num-clkdivs = <3>;
+
+ assigned-clocks = <&pm8998_clk_divs 1>,
+ <&pm8998_clk_divs 2>,
+ <&pm8998_clk_divs 3>;
+ assigned-clock-rates = <9600000>,
+ <9600000>,
+ <9600000>;
+ };
+ };
--
2.34.1


2022-12-26 22:40:42

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: clock: qcom,spmi-clkdiv: convert to DT schema


On Fri, 23 Dec 2022 12:18:35 +0100, Krzysztof Kozlowski wrote:
> Convert Qualcomm SPMI PMIC clock divider bindings to DT schema.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/clock/qcom,spmi-clkdiv.txt | 59 ---------------
> .../bindings/clock/qcom,spmi-clkdiv.yaml | 71 +++++++++++++++++++
> 2 files changed, 71 insertions(+), 59 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/clock/qcom,spmi-clkdiv.txt
> create mode 100644 Documentation/devicetree/bindings/clock/qcom,spmi-clkdiv.yaml
>

Reviewed-by: Rob Herring <[email protected]>

2023-01-11 05:41:36

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: clock: qcom,spmi-clkdiv: convert to DT schema

On Fri, 23 Dec 2022 12:18:35 +0100, Krzysztof Kozlowski wrote:
> Convert Qualcomm SPMI PMIC clock divider bindings to DT schema.
>
>

Applied, thanks!

[1/1] dt-bindings: clock: qcom,spmi-clkdiv: convert to DT schema
commit: 3c4af3ab1f68ddceb548094d680bc71806a09aee

Best regards,
--
Bjorn Andersson <[email protected]>