2022-12-23 19:55:59

by Rayyan Ansari

Subject: [PATCH 1/3] ARM: dts: qcom: pm8226: sort includes alphabetically and nodes by address

Sort the includes and nodes for consistency.

Signed-off-by: Rayyan Ansari <[email protected]>
---
arch/arm/boot/dts/qcom-pm8226.dtsi | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm/boot/dts/qcom-pm8226.dtsi b/arch/arm/boot/dts/qcom-pm8226.dtsi
index 9b7d9d04ded6..d99532ea70b2 100644
--- a/arch/arm/boot/dts/qcom-pm8226.dtsi
+++ b/arch/arm/boot/dts/qcom-pm8226.dtsi
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: BSD-3-Clause
+#include <dt-bindings/iio/qcom,spmi-vadc.h>
#include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/spmi/spmi.h>
-#include <dt-bindings/iio/qcom,spmi-vadc.h>

&spmi_bus {
pm8226_0: pm8226@0 {
@@ -41,13 +41,6 @@ smbb: charger@1000 {
chg_otg: otg-vbus { };
};

- rtc@6000 {
- compatible = "qcom,pm8941-rtc";
- reg = <0x6000>, <0x6100>;
- reg-names = "rtc", "alarm";
- interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>;
- };
-
pm8226_vadc: adc@3100 {
compatible = "qcom,spmi-vadc";
reg = <0x3100>;
@@ -81,6 +74,13 @@ adc-chan@f {
};
};

+ rtc@6000 {
+ compatible = "qcom,pm8941-rtc";
+ reg = <0x6000>, <0x6100>;
+ reg-names = "rtc", "alarm";
+ interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>;
+ };
+
pm8226_mpps: mpps@a000 {
compatible = "qcom,pm8226-mpp", "qcom,spmi-mpp";
reg = <0xa000>;
--
2.39.0

2022-12-26 12:47:57

by Luca Weiss

Subject: Re: [PATCH 1/3] ARM: dts: qcom: pm8226: sort includes alphabetically and nodes by address

On Freitag, 23. Dezember 2022 20:34:01 CET Rayyan Ansari wrote:
> Sort the includes and nodes for consistency.
>
> Signed-off-by: Rayyan Ansari <[email protected]>

Reviewed-by: Luca Weiss <[email protected]>

> ---
> arch/arm/boot/dts/qcom-pm8226.dtsi | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-pm8226.dtsi
> b/arch/arm/boot/dts/qcom-pm8226.dtsi index 9b7d9d04ded6..d99532ea70b2
> 100644
> --- a/arch/arm/boot/dts/qcom-pm8226.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8226.dtsi
> @@ -1,7 +1,7 @@
> // SPDX-License-Identifier: BSD-3-Clause
> +#include <dt-bindings/iio/qcom,spmi-vadc.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/spmi/spmi.h>
> -#include <dt-bindings/iio/qcom,spmi-vadc.h>
>
> &spmi_bus {
> pm8226_0: pm8226@0 {
> @@ -41,13 +41,6 @@ smbb: charger@1000 {
> chg_otg: otg-vbus { };
> };
>
> - rtc@6000 {
> - compatible = "qcom,pm8941-rtc";
> - reg = <0x6000>, <0x6100>;
> - reg-names = "rtc", "alarm";
> - interrupts = <0x0 0x61 0x1
IRQ_TYPE_EDGE_RISING>;
> - };
> -
> pm8226_vadc: adc@3100 {
> compatible = "qcom,spmi-vadc";
> reg = <0x3100>;
> @@ -81,6 +74,13 @@ adc-chan@f {
> };
> };
>
> + rtc@6000 {
> + compatible = "qcom,pm8941-rtc";
> + reg = <0x6000>, <0x6100>;
> + reg-names = "rtc", "alarm";
> + interrupts = <0x0 0x61 0x1
IRQ_TYPE_EDGE_RISING>;
> + };
> +
> pm8226_mpps: mpps@a000 {
> compatible = "qcom,pm8226-mpp", "qcom,spmi-
mpp";
> reg = <0xa000>;