2022-12-24 15:55:03

by Krzysztof Kozlowski

Subject: [PATCH 1/5] arm64: dts: qcom: msm8996: align bus node names with DT schema

The node names should be generic and the bindings expect "bus" for
simple-bus nodes:

msm8996-mtp.dtb: agnoc@0: $nodename:0: 'agnoc@0' does not match '^bus(@[0-9a-f]+)?$'

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index c53018ca81d7..cf2f5b74a4c2 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -1814,7 +1814,7 @@ spmi_bus: spmi@400f000 {
#interrupt-cells = <4>;
};

- agnoc@0 {
+ bus@0 {
power-domains = <&gcc AGGRE0_NOC_GDSC>;
compatible = "simple-pm-bus";
#address-cells = <1>;
--
2.34.1

2022-12-27 12:10:06

by Konrad Dybcio

Subject: Re: [PATCH 1/5] arm64: dts: qcom: msm8996: align bus node names with DT schema

On 24.12.2022 16:42, Krzysztof Kozlowski wrote:
> The node names should be generic and the bindings expect "bus" for
> simple-bus nodes:
>
> msm8996-mtp.dtb: agnoc@0: $nodename:0: 'agnoc@0' does not match '^bus(@[0-9a-f]+)?$'
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index c53018ca81d7..cf2f5b74a4c2 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -1814,7 +1814,7 @@ spmi_bus: spmi@400f000 {
> #interrupt-cells = <4>;
> };
>
> - agnoc@0 {
> + bus@0 {
> power-domains = <&gcc AGGRE0_NOC_GDSC>;
> compatible = "simple-pm-bus";
Mind sending a separate patch to move compatible up on this one?

Konrad
> #address-cells = <1>;

2022-12-29 17:42:39

by Bjorn Andersson

Subject: Re: (subset) [PATCH 1/5] arm64: dts: qcom: msm8996: align bus node names with DT schema

On Sat, 24 Dec 2022 16:42:51 +0100, Krzysztof Kozlowski wrote:
> The node names should be generic and the bindings expect "bus" for
> simple-bus nodes:
>
> msm8996-mtp.dtb: agnoc@0: $nodename:0: 'agnoc@0' does not match '^bus(@[0-9a-f]+)?$'
>
>

Applied, thanks!

[1/5] arm64: dts: qcom: msm8996: align bus node names with DT schema
commit: 496b308f0988f3fb610073e125da8ef8065b334f
[3/5] arm64: dts: qcom: sm8250: drop unused clock-frequency from va-macro
commit: 42db0f72f7a8c33501a55537ac90557a665a56f8
[4/5] arm64: dts: qcom: sm8450: re-order GCC clocks
commit: 539a9923683c79e6925dd69a2e2534ec197361c7
[5/5] arm64: dts: qcom: use generic node name for CS35L41 speaker
commit: 9e8e9be6c499d3dfa408b7306004c4b981622ff1

Best regards,
--
Bjorn Andersson <[email protected]>