2022-12-28 06:38:37

by Biao Huang (黄彪)

[permalink] [raw]
Subject: [PATCH v6 0/2] arm64: dts: mt8195: Add Ethernet controller

Changes in v6:
1. add reviewed-by as Angelo's comments
2. remove fix_mac_speed in driver as Andrew's comments.

Changes in v5:
1. reorder the clocks as Angelo's comments
2. add a driver patch to fix rgmii-id issue, then we can
use a ususal way rgmii/rgmii-id as Andrew's comments.

Changes in v4:
1. remove {address,size}-cells = <0> to avoid warning as Angelo's feedback.
2. Add reviewd-by as Angelo's comments.

Changes in v3:
1. move stmmac-axi-config, rx-queues-config, tx-queues-configs inside ethernet
node as Angelo's comments.
2. add {address,size}-cells = <0> in ethernet node as Angelo's comments.

Changes in v2:
1. modify pinctrl node used by ethernet to match rules in pinctrl-mt8195.yaml,
which is pointed by Krzysztof.
2. remove "mac-address" property in ethernet node as comments of Krzysztof.

Changes in v1:
add dts node for MT8195 Ethernet controller

Biao Huang (2):
stmmac: dwmac-mediatek: remove the dwmac_fix_mac_speed
arm64: dts: mt8195: Add Ethernet controller

arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 81 +++++++++++++++++
arch/arm64/boot/dts/mediatek/mt8195.dtsi | 86 +++++++++++++++++++
.../ethernet/stmicro/stmmac/dwmac-mediatek.c | 26 ------
3 files changed, 167 insertions(+), 26 deletions(-)

--
2.18.0



2022-12-30 01:37:53

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH v6 0/2] arm64: dts: mt8195: Add Ethernet controller

On Wed, 28 Dec 2022 14:33:28 +0800 Biao Huang wrote:
> Changes in v6:
> 1. add reviewed-by as Angelo's comments
> 2. remove fix_mac_speed in driver as Andrew's comments.
>
> Changes in v5:
> 1. reorder the clocks as Angelo's comments
> 2. add a driver patch to fix rgmii-id issue, then we can
> use a ususal way rgmii/rgmii-id as Andrew's comments.
>
> Changes in v4:
> 1. remove {address,size}-cells = <0> to avoid warning as Angelo's feedback.
> 2. Add reviewd-by as Angelo's comments.
>
> Changes in v3:
> 1. move stmmac-axi-config, rx-queues-config, tx-queues-configs inside ethernet
> node as Angelo's comments.
> 2. add {address,size}-cells = <0> in ethernet node as Angelo's comments.
>
> Changes in v2:
> 1. modify pinctrl node used by ethernet to match rules in pinctrl-mt8195.yaml,
> which is pointed by Krzysztof.
> 2. remove "mac-address" property in ethernet node as comments of Krzysztof.

Please make sure to CC netdev@ on the next version of the patches.

2022-12-30 02:20:29

by Biao Huang (黄彪)

[permalink] [raw]
Subject: Re: [PATCH v6 0/2] arm64: dts: mt8195: Add Ethernet controller

On Thu, 2022-12-29 at 17:15 -0800, Jakub Kicinski wrote:
> On Wed, 28 Dec 2022 14:33:28 +0800 Biao Huang wrote:
> > Changes in v6:
> > 1. add reviewed-by as Angelo's comments
> > 2. remove fix_mac_speed in driver as Andrew's comments.
> >
> > Changes in v5:
> > 1. reorder the clocks as Angelo's comments
> > 2. add a driver patch to fix rgmii-id issue, then we can
> > use a ususal way rgmii/rgmii-id as Andrew's comments.
> >
> > Changes in v4:
> > 1. remove {address,size}-cells = <0> to avoid warning as Angelo's
> > feedback.
> > 2. Add reviewd-by as Angelo's comments.
> >
> > Changes in v3:
> > 1. move stmmac-axi-config, rx-queues-config, tx-queues-configs
> > inside ethernet
> > node as Angelo's comments.
> > 2. add {address,size}-cells = <0> in ethernet node as Angelo's
> > comments.
> >
> > Changes in v2:
> > 1. modify pinctrl node used by ethernet to match rules in pinctrl-
> > mt8195.yaml,
> > which is pointed by Krzysztof.
> > 2. remove "mac-address" property in ethernet node as comments of
> > Krzysztof.
>
> Please make sure to CC netdev@ on the next version of the patches.
Thanks for your kindly reminder.

Best Regards!
Biao