Hello,
The following patches sort the nodes and includes in PM8226's
device tree file, and add new nodes for PON (with the resin sub-node)
and IADC.
Changes since v1:
- Use adc@ generic node name
- Use specific PM8226 IADC compatible with fallback
- Document PM8226 IADC compatible
Rayyan Ansari (4):
ARM: dts: qcom: pm8226: sort includes alphabetically and nodes by
address
ARM: dts: qcom: pm8226: add PON device node along with resin sub-node
ARM: dts: qcom: pm8226: add IADC node
dt-bindings: iio/adc: qcom,spmi-iadc: document PM8226 compatible
.../bindings/iio/adc/qcom,spmi-iadc.yaml | 1 +
arch/arm/boot/dts/qcom-pm8226.dtsi | 46 +++++++++++++------
2 files changed, 34 insertions(+), 13 deletions(-)
--
2.39.0
Document the compatible for the IADC used on PM8226.
Signed-off-by: Rayyan Ansari <[email protected]>
---
Documentation/devicetree/bindings/iio/adc/qcom,spmi-iadc.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-iadc.yaml b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-iadc.yaml
index fa855baa368c..18aaf6df179d 100644
--- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-iadc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-iadc.yaml
@@ -20,6 +20,7 @@ properties:
compatible:
items:
- enum:
+ - qcom,pm8226-iadc
- qcom,pm8941-iadc
- const: qcom,spmi-iadc
--
2.39.0
The PON (Power On) device in PM8226 supports both the power key and
resin (reset input).
The reset input is usually connected to a physical volume up/down button.
Signed-off-by: Rayyan Ansari <[email protected]>
---
arch/arm/boot/dts/qcom-pm8226.dtsi | 24 +++++++++++++++++++-----
1 file changed, 19 insertions(+), 5 deletions(-)
diff --git a/arch/arm/boot/dts/qcom-pm8226.dtsi b/arch/arm/boot/dts/qcom-pm8226.dtsi
index a2092569970a..6af259218f63 100644
--- a/arch/arm/boot/dts/qcom-pm8226.dtsi
+++ b/arch/arm/boot/dts/qcom-pm8226.dtsi
@@ -1,5 +1,6 @@
// SPDX-License-Identifier: BSD-3-Clause
#include <dt-bindings/iio/qcom,spmi-vadc.h>
+#include <dt-bindings/input/linux-event-codes.h>
#include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/spmi/spmi.h>
@@ -10,12 +11,25 @@ pm8226_0: pm8226@0 {
#address-cells = <1>;
#size-cells = <0>;
- pwrkey@800 {
- compatible = "qcom,pm8941-pwrkey";
+ pon@800 {
+ compatible = "qcom,pm8916-pon";
reg = <0x800>;
- interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
- debounce = <15625>;
- bias-pull-up;
+
+ pwrkey {
+ compatible = "qcom,pm8941-pwrkey";
+ interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
+ debounce = <15625>;
+ bias-pull-up;
+ linux,code = <KEY_POWER>;
+ };
+
+ pm8226_resin: resin {
+ compatible = "qcom,pm8941-resin";
+ interrupts = <0x0 0x8 1 IRQ_TYPE_EDGE_BOTH>;
+ debounce = <15625>;
+ bias-pull-up;
+ status = "disabled";
+ };
};
smbb: charger@1000 {
--
2.39.0
On 29/12/2022 00:04, Rayyan Ansari wrote:
> Document the compatible for the IADC used on PM8226.
>
> Signed-off-by: Rayyan Ansari <[email protected]>
Acked-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
On 29.12.2022 00:04, Rayyan Ansari wrote:
> The PON (Power On) device in PM8226 supports both the power key and
> resin (reset input).
> The reset input is usually connected to a physical volume up/down button.
>
> Signed-off-by: Rayyan Ansari <[email protected]>
> ---
> arch/arm/boot/dts/qcom-pm8226.dtsi | 24 +++++++++++++++++++-----
> 1 file changed, 19 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-pm8226.dtsi b/arch/arm/boot/dts/qcom-pm8226.dtsi
> index a2092569970a..6af259218f63 100644
> --- a/arch/arm/boot/dts/qcom-pm8226.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8226.dtsi
> @@ -1,5 +1,6 @@
> // SPDX-License-Identifier: BSD-3-Clause
> #include <dt-bindings/iio/qcom,spmi-vadc.h>
> +#include <dt-bindings/input/linux-event-codes.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/spmi/spmi.h>
>
> @@ -10,12 +11,25 @@ pm8226_0: pm8226@0 {
> #address-cells = <1>;
> #size-cells = <0>;
>
> - pwrkey@800 {
> - compatible = "qcom,pm8941-pwrkey";
> + pon@800 {
> + compatible = "qcom,pm8916-pon";
> reg = <0x800>;
> - interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
> - debounce = <15625>;
> - bias-pull-up;
> +
> + pwrkey {
> + compatible = "qcom,pm8941-pwrkey";
> + interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
> + debounce = <15625>;
> + bias-pull-up;
> + linux,code = <KEY_POWER>;
That's redundant, the driver sets this by default if linux,code is
not found.
Konrad
> + };
> +
> + pm8226_resin: resin {
> + compatible = "qcom,pm8941-resin";
> + interrupts = <0x0 0x8 1 IRQ_TYPE_EDGE_BOTH>;
> + debounce = <15625>;
> + bias-pull-up;
> + status = "disabled";
> + };
> };
>
> smbb: charger@1000 {
On Thu, 29 Dec 2022 09:47:27 +0100
Krzysztof Kozlowski <[email protected]> wrote:
> On 29/12/2022 00:04, Rayyan Ansari wrote:
> > Document the compatible for the IADC used on PM8226.
> >
> > Signed-off-by: Rayyan Ansari <[email protected]>
>
>
> Acked-by: Krzysztof Kozlowski <[email protected]>
Applied to the togreg branch of iio.git and initially pushed out as testing for 0-day
to take a poke at it.
Thanks,
Jonathan
>
> Best regards,
> Krzysztof
>