2022-12-30 17:41:14

by Federico Vaga

Subject: [PATCH V2] doc: fix typo in botching up ioctls

The type contained a typo `uintprt` -> `uintptr`

Signed-off-by: Federico Vaga <[email protected]>
---
Documentation/process/botching-up-ioctls.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

v1 -> v2 fix the typo in the commit message

diff --git a/Documentation/process/botching-up-ioctls.rst b/Documentation/process/botching-up-ioctls.rst
index ba4667ab396b..9739b88463a5 100644
--- a/Documentation/process/botching-up-ioctls.rst
+++ b/Documentation/process/botching-up-ioctls.rst
@@ -41,7 +41,7 @@ will need to add a 32-bit compat layer:
structures to the kernel, or if the kernel checks the structure size, which
e.g. the drm core does.

- * Pointers are __u64, cast from/to a uintprt_t on the userspace side and
+ * Pointers are __u64, cast from/to a uintptr_t on the userspace side and
from/to a void __user * in the kernel. Try really hard not to delay this
conversion or worse, fiddle the raw __u64 through your code since that
diminishes the checking tools like sparse can provide. The macro
--
2.30.2

2022-12-30 21:46:13

by Randy Dunlap

Subject: Re: [PATCH V2] doc: fix typo in botching up ioctls

On 12/30/22 09:23, Federico Vaga wrote:
> The type contained a typo `uintprt` -> `uintptr`
>
> Signed-off-by: Federico Vaga <[email protected]>


Acked-by: Randy Dunlap <[email protected]>

Thanks.

> ---
> Documentation/process/botching-up-ioctls.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> v1 -> v2 fix the typo in the commit message
>
> diff --git a/Documentation/process/botching-up-ioctls.rst b/Documentation/process/botching-up-ioctls.rst
> index ba4667ab396b..9739b88463a5 100644
> --- a/Documentation/process/botching-up-ioctls.rst
> +++ b/Documentation/process/botching-up-ioctls.rst
> @@ -41,7 +41,7 @@ will need to add a 32-bit compat layer:
> structures to the kernel, or if the kernel checks the structure size, which
> e.g. the drm core does.
>
> - * Pointers are __u64, cast from/to a uintprt_t on the userspace side and
> + * Pointers are __u64, cast from/to a uintptr_t on the userspace side and
> from/to a void __user * in the kernel. Try really hard not to delay this
> conversion or worse, fiddle the raw __u64 through your code since that
> diminishes the checking tools like sparse can provide. The macro

--
~Randy

2023-01-11 23:30:18

by Jonathan Corbet

Subject: Re: [PATCH V2] doc: fix typo in botching up ioctls

Federico Vaga <[email protected]> writes:

> The type contained a typo `uintprt` -> `uintptr`
>
> Signed-off-by: Federico Vaga <[email protected]>
> ---
> Documentation/process/botching-up-ioctls.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> v1 -> v2 fix the typo in the commit message
>
> diff --git a/Documentation/process/botching-up-ioctls.rst b/Documentation/process/botching-up-ioctls.rst
> index ba4667ab396b..9739b88463a5 100644
> --- a/Documentation/process/botching-up-ioctls.rst
> +++ b/Documentation/process/botching-up-ioctls.rst
> @@ -41,7 +41,7 @@ will need to add a 32-bit compat layer:
> structures to the kernel, or if the kernel checks the structure size, which
> e.g. the drm core does.
>
> - * Pointers are __u64, cast from/to a uintprt_t on the userspace side and
> + * Pointers are __u64, cast from/to a uintptr_t on the userspace side and
> from/to a void __user * in the kernel. Try really hard not to delay this

Applied, thanks.

jon