LinuxLists.cc - [PATCH v2 1/2] ARM: dts: sunxi: Fix GPIO LED node names

2022-12-31 23:14:52

Subject: [PATCH v2 1/2] ARM: dts: sunxi: Fix GPIO LED node names

These board devicetrees fail to validate because the gpio-leds schema
requires its child nodes to have "led" in the node name.

Signed-off-by: Samuel Holland <[email protected]>
---

Changes in v2:
- Use the recommended enumerator pattern for LED node names

arch/arm/boot/dts/sun5i-gr8-chip-pro.dts | 2 +-
arch/arm/boot/dts/sun5i-r8-chip.dts | 2 +-
arch/arm/boot/dts/sun6i-a31s-sina31s.dts | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts b/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts
index a32cde3e32eb..5c3562b85a5b 100644
--- a/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts
+++ b/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts
@@ -70,7 +70,7 @@ chosen {
leds {
compatible = "gpio-leds";

- status {
+ led-0 {
label = "chip-pro:white:status";
gpios = <&axp_gpio 2 GPIO_ACTIVE_HIGH>;
default-state = "on";
diff --git a/arch/arm/boot/dts/sun5i-r8-chip.dts b/arch/arm/boot/dts/sun5i-r8-chip.dts
index 4bf4943d4eb7..fd37bd1f3920 100644
--- a/arch/arm/boot/dts/sun5i-r8-chip.dts
+++ b/arch/arm/boot/dts/sun5i-r8-chip.dts
@@ -70,7 +70,7 @@ chosen {
leds {
compatible = "gpio-leds";

- status {
+ led-0 {
label = "chip:white:status";
gpios = <&axp_gpio 2 GPIO_ACTIVE_HIGH>;
default-state = "on";
diff --git a/arch/arm/boot/dts/sun6i-a31s-sina31s.dts b/arch/arm/boot/dts/sun6i-a31s-sina31s.dts
index 0af48e143b66..56956352914d 100644
--- a/arch/arm/boot/dts/sun6i-a31s-sina31s.dts
+++ b/arch/arm/boot/dts/sun6i-a31s-sina31s.dts
@@ -67,7 +67,7 @@ hdmi_con_in: endpoint {
leds {
compatible = "gpio-leds";

- status {
+ led-0 {
label = "sina31s:status:usr";
gpios = <&pio 7 13 GPIO_ACTIVE_HIGH>; /* PH13 */
};
--
2.37.4

2023-01-03 11:32:44

by Andre Przywara

[permalink] [raw]

Subject: Re: [PATCH v2 1/2] ARM: dts: sunxi: Fix GPIO LED node names

On Sat, 31 Dec 2022 16:58:53 -0600
Samuel Holland <[email protected]> wrote:

> These board devicetrees fail to validate because the gpio-leds schema
> requires its child nodes to have "led" in the node name.
>
> Signed-off-by: Samuel Holland <[email protected]>

Reviewed-by: Andre Przywara <[email protected]>

Cheers,
Andre

> ---
>
> Changes in v2:
> - Use the recommended enumerator pattern for LED node names
>
> arch/arm/boot/dts/sun5i-gr8-chip-pro.dts | 2 +-
> arch/arm/boot/dts/sun5i-r8-chip.dts | 2 +-
> arch/arm/boot/dts/sun6i-a31s-sina31s.dts | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts b/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts
> index a32cde3e32eb..5c3562b85a5b 100644
> --- a/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts
> +++ b/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts
> @@ -70,7 +70,7 @@ chosen {
> leds {
> compatible = "gpio-leds";
>
> - status {
> + led-0 {
> label = "chip-pro:white:status";
> gpios = <&axp_gpio 2 GPIO_ACTIVE_HIGH>;
> default-state = "on";
> diff --git a/arch/arm/boot/dts/sun5i-r8-chip.dts b/arch/arm/boot/dts/sun5i-r8-chip.dts
> index 4bf4943d4eb7..fd37bd1f3920 100644
> --- a/arch/arm/boot/dts/sun5i-r8-chip.dts
> +++ b/arch/arm/boot/dts/sun5i-r8-chip.dts
> @@ -70,7 +70,7 @@ chosen {
> leds {
> compatible = "gpio-leds";
>
> - status {
> + led-0 {
> label = "chip:white:status";
> gpios = <&axp_gpio 2 GPIO_ACTIVE_HIGH>;
> default-state = "on";
> diff --git a/arch/arm/boot/dts/sun6i-a31s-sina31s.dts b/arch/arm/boot/dts/sun6i-a31s-sina31s.dts
> index 0af48e143b66..56956352914d 100644
> --- a/arch/arm/boot/dts/sun6i-a31s-sina31s.dts
> +++ b/arch/arm/boot/dts/sun6i-a31s-sina31s.dts
> @@ -67,7 +67,7 @@ hdmi_con_in: endpoint {
> leds {
> compatible = "gpio-leds";
>
> - status {
> + led-0 {
> label = "sina31s:status:usr";
> gpios = <&pio 7 13 GPIO_ACTIVE_HIGH>; /* PH13 */
> };

2023-01-05 16:33:25

by Jernej Škrabec

[permalink] [raw]

Subject: Re: [PATCH v2 1/2] ARM: dts: sunxi: Fix GPIO LED node names

Dne sobota, 31. december 2022 ob 23:58:53 CET je Samuel Holland napisal(a):
> These board devicetrees fail to validate because the gpio-leds schema
> requires its child nodes to have "led" in the node name.
>
> Signed-off-by: Samuel Holland <[email protected]>

Reviewed-by: Jernej Skrabec <[email protected]>

Best regards,
Jernej

2023-01-08 21:14:32

by Jernej Škrabec

[permalink] [raw]