2023-01-04 08:12:41

by xurui

Subject: [PATCH] coredump: Fix a compilation issue with CONFIG_VLYNQ_DEBUG=y

A compilation issue occurred when CONFIG_VLYNQ_DEBUG is set:
drivers/vlynq/vlynq.c:82:13: error: ‘vlynq_dump_mem’ defined but not used [-Werror=unused-function]
drivers/vlynq/vlynq.c:68:13: error: ‘vlynq_dump_regs’ defined but not used [-Werror=unused-function]

Signed-off-by: xurui <[email protected]>
---
drivers/vlynq/vlynq.c | 28 ----------------------------
1 file changed, 28 deletions(-)

diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c
index 4af6615808cc..6bff9651f699 100644
--- a/drivers/vlynq/vlynq.c
+++ b/drivers/vlynq/vlynq.c
@@ -64,34 +64,6 @@ struct vlynq_regs {
u32 int_device[8];
};

-#ifdef CONFIG_VLYNQ_DEBUG
-static void vlynq_dump_regs(struct vlynq_device *dev)
-{
- int i;
-
- printk(KERN_DEBUG "VLYNQ local=%p remote=%p\n",
- dev->local, dev->remote);
- for (i = 0; i < 32; i++) {
- printk(KERN_DEBUG "VLYNQ: local %d: %08x\n",
- i + 1, ((u32 *)dev->local)[i]);
- printk(KERN_DEBUG "VLYNQ: remote %d: %08x\n",
- i + 1, ((u32 *)dev->remote)[i]);
- }
-}
-
-static void vlynq_dump_mem(u32 *base, int count)
-{
- int i;
-
- for (i = 0; i < (count + 3) / 4; i++) {
- if (i % 4 == 0)
- printk(KERN_DEBUG "\nMEM[0x%04x]:", i * 4);
- printk(KERN_DEBUG " 0x%08x", *(base + i));
- }
- printk(KERN_DEBUG "\n");
-}
-#endif
-
/* Check the VLYNQ link status with a given device */
static int vlynq_linked(struct vlynq_device *dev)
{
--
2.25.1

2023-01-04 18:52:38

by Florian Fainelli

Subject: Re: [PATCH] coredump: Fix a compilation issue with CONFIG_VLYNQ_DEBUG=y

On 1/3/23 23:38, xurui wrote:
> A compilation issue occurred when CONFIG_VLYNQ_DEBUG is set:
> drivers/vlynq/vlynq.c:82:13: error: ‘vlynq_dump_mem’ defined but not used [-Werror=unused-function]
> drivers/vlynq/vlynq.c:68:13: error: ‘vlynq_dump_regs’ defined but not used [-Werror=unused-function]
>
> Signed-off-by: xurui <[email protected]>

The subject should be: vlynq: Fix a compilation with
CONFIG_VLYNQ_DEBUG=y. I could fix that up while applying this for you.
--
Florian