LinuxLists.cc - [PATCH] mm/page_alloc: Repalce with deferred_pages

2023-01-05 08:41:08

Subject: [PATCH] mm/page_alloc: Repalce with deferred_pages_enabled() wherever applicable

Instead of directly accessing static deferred_pages, replace such instances
with the helper deferred_pages_enabled(). No functional change is intended.

Cc; Andrew Morton <[email protected]>
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Anshuman Khandual <[email protected]>
---
This applies on v6.2-rc2.

mm/page_alloc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 0745aedebb37..232d0323047b 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -4244,7 +4244,7 @@ get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags,
* Watermark failed for this zone, but see if we can
* grow this zone if it contains deferred pages.
*/
- if (static_branch_unlikely(&deferred_pages)) {
+ if (deferred_pages_enabled()) {
if (_deferred_grow_zone(zone, order))
goto try_this_zone;
}
@@ -4293,7 +4293,7 @@ get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags,
} else {
#ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT
/* Try again if zone has deferred pages */
- if (static_branch_unlikely(&deferred_pages)) {
+ if (deferred_pages_enabled()) {
if (_deferred_grow_zone(zone, order))
goto try_this_zone;
}
--
2.25.1

2023-01-05 09:55:33

by Mike Rapoport

[permalink] [raw]

Subject: Re: [PATCH] mm/page_alloc: Repalce with deferred_pages_enabled() wherever applicable

On Thu, Jan 05, 2023 at 01:55:06PM +0530, Anshuman Khandual wrote:
> Instead of directly accessing static deferred_pages, replace such instances
> with the helper deferred_pages_enabled(). No functional change is intended.
>
> Cc; Andrew Morton <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Anshuman Khandual <[email protected]>

Reviewed-by: Mike Rapoport (IBM) <[email protected]>

> ---
> This applies on v6.2-rc2.
>
> mm/page_alloc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 0745aedebb37..232d0323047b 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -4244,7 +4244,7 @@ get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags,
> * Watermark failed for this zone, but see if we can
> * grow this zone if it contains deferred pages.
> */
> - if (static_branch_unlikely(&deferred_pages)) {
> + if (deferred_pages_enabled()) {
> if (_deferred_grow_zone(zone, order))
> goto try_this_zone;
> }
> @@ -4293,7 +4293,7 @@ get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags,
> } else {
> #ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT
> /* Try again if zone has deferred pages */
> - if (static_branch_unlikely(&deferred_pages)) {
> + if (deferred_pages_enabled()) {
> if (_deferred_grow_zone(zone, order))
> goto try_this_zone;
> }
> --
> 2.25.1
>

--
Sincerely yours,
Mike.

2023-01-05 13:19:25

by David Hildenbrand

[permalink] [raw]

Subject: Re: [PATCH] mm/page_alloc: Repalce with deferred_pages_enabled() wherever applicable

s/Repalce/Replace/

n 05.01.23 09:25, Anshuman Khandual wrote:
> Instead of directly accessing static deferred_pages, replace such instances
> with the helper deferred_pages_enabled(). No functional change is intended.
>
> Cc; Andrew Morton <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Anshuman Khandual <[email protected]>
> ---

Reviewed-by: David Hildenbrand <[email protected]>

--
Thanks,

David / dhildenb

2023-01-09 14:05:09

by Mel Gorman

[permalink] [raw]