2023-01-06 01:14:20

by Yang Li

Subject: [PATCH -next] speakup: Fix warning comparing pointer to 0

./drivers/accessibility/speakup/utils.h:39:15-16: WARNING comparing pointer to 0

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3636
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/accessibility/speakup/utils.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h
index 4ce9a12f7664..db00c962f8e2 100644
--- a/drivers/accessibility/speakup/utils.h
+++ b/drivers/accessibility/speakup/utils.h
@@ -36,7 +36,7 @@ static inline void open_input(const char *dir_name, const char *name)
else
snprintf(filename, sizeof(filename), "%s", name);
infile = fopen(filename, "r");
- if (infile == 0) {
+ if (!infile) {
fprintf(stderr, "can't open %s\n", filename);
exit(1);
}
--
2.20.1.7.g153144c

2023-01-06 01:16:47

by Samuel Thibault

Subject: Re: [PATCH -next] speakup: Fix warning comparing pointer to 0

Yang Li, le ven. 06 janv. 2023 08:41:14 +0800, a ecrit:
> ./drivers/accessibility/speakup/utils.h:39:15-16: WARNING comparing pointer to 0
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3636
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>

Reviewed-by: Samuel Thibault <[email protected]>

> ---
> drivers/accessibility/speakup/utils.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h
> index 4ce9a12f7664..db00c962f8e2 100644
> --- a/drivers/accessibility/speakup/utils.h
> +++ b/drivers/accessibility/speakup/utils.h
> @@ -36,7 +36,7 @@ static inline void open_input(const char *dir_name, const char *name)
> else
> snprintf(filename, sizeof(filename), "%s", name);
> infile = fopen(filename, "r");
> - if (infile == 0) {
> + if (!infile) {
> fprintf(stderr, "can't open %s\n", filename);
> exit(1);
> }
> --
> 2.20.1.7.g153144c
>

--
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.