2023-01-06 08:33:13

by oushixiong

Subject: [PATCH] afs: fix a compilation issue

fix a compilation issue:
error: no return statement in function returning non-void

Reported-by: k2ci <[email protected]>
Signed-off-by: oushixiong <[email protected]>
---
fs/afs/dir.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/fs/afs/dir.c b/fs/afs/dir.c
index b7c1f8c84b38..0522fb61b929 100644
--- a/fs/afs/dir.c
+++ b/fs/afs/dir.c
@@ -49,6 +49,7 @@ static bool afs_dir_dirty_folio(struct address_space *mapping,
struct folio *folio)
{
BUG(); /* This should never happen. */
+ return false;
}

const struct file_operations afs_dir_file_operations = {
--
2.25.1

2023-01-06 13:51:48

by David Howells

Subject: Re: [PATCH] afs: fix a compilation issue

oushixiong <[email protected]> wrote:

> BUG(); /* This should never happen. */
> + return false;

This isn't necessary. BUG() should be no-return.

David