LinuxLists.cc - [PATCH v2 3/3] arm64: dts: qcom: Add device tree for Samsung Galaxy Tab A 8.0 (2015)

2023-01-06 12:28:15

Subject: [PATCH v2 3/3] arm64: dts: qcom: Add device tree for Samsung Galaxy Tab A 8.0 (2015)

From: Siddharth Manthan <[email protected]>

Galaxy Tab A 8.0 is a tablet, very similar to Tab A 9.7 with major
differences being the display and touchscreen.

Add it's devicetree reusing a common dtsi from gt510.

Signed-off-by: Siddharth Manthan <[email protected]>
[Squashed multiple commits]
Signed-off-by: Nikita Travkin <[email protected]>
---
arch/arm64/boot/dts/qcom/Makefile | 1 +
.../boot/dts/qcom/msm8916-samsung-gt58.dts | 78 +++++++++++++++++++
2 files changed, 79 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/msm8916-samsung-gt58.dts

diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 70e3b109aeff..062561db33f1 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -20,6 +20,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-e5.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-e7.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-grandmax.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-gt510.dtb
+dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-gt58.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-j5.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-serranove.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-wingtech-wt88047.dtb
diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-gt58.dts b/arch/arm64/boot/dts/qcom/msm8916-samsung-gt58.dts
new file mode 100644
index 000000000000..fcf516888739
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-gt58.dts
@@ -0,0 +1,78 @@
+// SPDX-License-Identifier: GPL-2.0-only
+
+/dts-v1/;
+
+#include "msm8916-samsung-gt5-common.dtsi"
+
+/ {
+ model = "Samsung Galaxy Tab A 8.0 (2015)";
+ compatible = "samsung,gt58", "qcom,msm8916";
+ chassis-type = "tablet";
+
+ reg_vdd_tsp: regulator-vdd-tsp {
+ compatible = "regulator-fixed";
+ regulator-name = "vdd_tsp";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+
+ gpio = <&msmgpio 73 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+
+ pinctrl-0 = <&reg_tsp_en_default>;
+ pinctrl-names = "default";
+ };
+
+ vibrator {
+ compatible = "gpio-vibrator";
+ enable-gpios = <&msmgpio 76 GPIO_ACTIVE_HIGH>;
+
+ pinctrl-0 = <&vibrator_en_default>;
+ pinctrl-names = "default";
+ };
+};
+
+&blsp_i2c5 {
+ status = "okay";
+
+ touchscreen@20 {
+ compatible = "zinitix,bt532";
+ reg = <0x20>;
+ interrupt-parent = <&msmgpio>;
+ interrupts = <13 IRQ_TYPE_EDGE_FALLING>;
+
+ touchscreen-size-x = <768>;
+ touchscreen-size-y = <1024>;
+
+ vcca-supply = <&reg_vdd_tsp>;
+ vdd-supply = <&pm8916_l6>;
+
+ pinctrl-0 = <&tsp_int_default>;
+ pinctrl-names = "default";
+ };
+};
+
+&msmgpio {
+ reg_tsp_en_default: reg-tsp-en-default-state {
+ pins = "gpio73";
+ function = "gpio";
+
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ tsp_int_default: tsp-int-default-state {
+ pins = "gpio13";
+ function = "gpio";
+
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ vibrator_en_default: vibrator-en-default-state {
+ pins = "gpio76";
+ function = "gpio";
+
+ drive-strength = <2>;
+ bias-disable;
+ };
+};
--
2.38.1

2023-01-07 10:55:18

by Konrad Dybcio

[permalink] [raw]

Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: Add device tree for Samsung Galaxy Tab A 8.0 (2015)

On 6.01.2023 13:25, Nikita Travkin wrote:
> From: Siddharth Manthan <[email protected]>
>
> Galaxy Tab A 8.0 is a tablet, very similar to Tab A 9.7 with major
> differences being the display and touchscreen.
>
> Add it's devicetree reusing a common dtsi from gt510.
>
> Signed-off-by: Siddharth Manthan <[email protected]>
> [Squashed multiple commits]
> Signed-off-by: Nikita Travkin <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/Makefile | 1 +
> .../boot/dts/qcom/msm8916-samsung-gt58.dts | 78 +++++++++++++++++++
> 2 files changed, 79 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/msm8916-samsung-gt58.dts
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 70e3b109aeff..062561db33f1 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -20,6 +20,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-e5.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-e7.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-grandmax.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-gt510.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-gt58.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-j5.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-serranove.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8916-wingtech-wt88047.dtb
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-gt58.dts b/arch/arm64/boot/dts/qcom/msm8916-samsung-gt58.dts
> new file mode 100644
> index 000000000000..fcf516888739
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-gt58.dts
> @@ -0,0 +1,78 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +
> +/dts-v1/;
> +
> +#include "msm8916-samsung-gt5-common.dtsi"
> +
> +/ {
> + model = "Samsung Galaxy Tab A 8.0 (2015)";
> + compatible = "samsung,gt58", "qcom,msm8916";
> + chassis-type = "tablet";
> +
> + reg_vdd_tsp: regulator-vdd-tsp {
> + compatible = "regulator-fixed";
> + regulator-name = "vdd_tsp";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> +
> + gpio = <&msmgpio 73 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> +
> + pinctrl-0 = <&reg_tsp_en_default>;
> + pinctrl-names = "default";
> + };
> +
> + vibrator {
> + compatible = "gpio-vibrator";
> + enable-gpios = <&msmgpio 76 GPIO_ACTIVE_HIGH>;
> +
> + pinctrl-0 = <&vibrator_en_default>;
> + pinctrl-names = "default";
> + };
> +};
> +
> +&blsp_i2c5 {
> + status = "okay";
> +
> + touchscreen@20 {
> + compatible = "zinitix,bt532";
> + reg = <0x20>;
> + interrupt-parent = <&msmgpio>;
> + interrupts = <13 IRQ_TYPE_EDGE_FALLING>;
> +
> + touchscreen-size-x = <768>;
> + touchscreen-size-y = <1024>;
> +
> + vcca-supply = <&reg_vdd_tsp>;
> + vdd-supply = <&pm8916_l6>;
> +
> + pinctrl-0 = <&tsp_int_default>;
> + pinctrl-names = "default";
> + };
> +};
> +
> +&msmgpio {
> + reg_tsp_en_default: reg-tsp-en-default-state {
> + pins = "gpio73";
> + function = "gpio";
> +
Stray newlines, please remove.

With that:

Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> + drive-strength = <2>;
> + bias-disable;
> + };
> +
> + tsp_int_default: tsp-int-default-state {
> + pins = "gpio13";
> + function = "gpio";
> +
> + drive-strength = <2>;
> + bias-disable;
> + };
> +
> + vibrator_en_default: vibrator-en-default-state {
> + pins = "gpio76";
> + function = "gpio";
> +
> + drive-strength = <2>;
> + bias-disable;
> + };
> +};