2023-01-09 04:05:10

by Chao Yu

Subject: [PATCH] f2fs: remove unneeded f2fs_cp_error() in f2fs_create_whiteout()

f2fs_rename() has checked CP_ERROR_FLAG, so remove redundant check
in f2fs_create_whiteout().

Signed-off-by: Chao Yu <[email protected]>
---
fs/f2fs/namei.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
index 6032589099ce..82923273f4bb 100644
--- a/fs/f2fs/namei.c
+++ b/fs/f2fs/namei.c
@@ -926,9 +926,6 @@ static int f2fs_tmpfile(struct user_namespace *mnt_userns, struct inode *dir,
static int f2fs_create_whiteout(struct user_namespace *mnt_userns,
struct inode *dir, struct inode **whiteout)
{
- if (unlikely(f2fs_cp_error(F2FS_I_SB(dir))))
- return -EIO;
-
return __f2fs_tmpfile(mnt_userns, dir, NULL,
S_IFCHR | WHITEOUT_MODE, true, whiteout);
}
--
2.25.1

2023-01-30 23:03:27

by patchwork-bot+f2fs

Subject: Re: [f2fs-dev] [PATCH] f2fs: remove unneeded f2fs_cp_error() in f2fs_create_whiteout()

Hello:

This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:

On Mon, 9 Jan 2023 11:47:34 +0800 you wrote:
> f2fs_rename() has checked CP_ERROR_FLAG, so remove redundant check
> in f2fs_create_whiteout().
>
> Signed-off-by: Chao Yu <[email protected]>
> ---
> fs/f2fs/namei.c | 3 ---
> 1 file changed, 3 deletions(-)

Here is the summary with links:
- [f2fs-dev] f2fs: remove unneeded f2fs_cp_error() in f2fs_create_whiteout()
https://git.kernel.org/jaegeuk/f2fs/c/8abe4be45132

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html