2023-01-09 03:54:35

by Sibi Sankar

Subject: [PATCH V2 02/11] dt-bindings: remoteproc: qcom,msm8996-mss-pil: Update memory region

The dynamic memory region used for metadata authentication would still
be a part of the kernel mapping and any access to this region by the
application processor after assigning it to the remote Q6 will result
in a XPU violation. This is fixed by using a no-map carveout instead.
Update the bindings to reflect the addition of the new modem metadata
carveout on MSM8996 (and similar) SoCs.

Signed-off-by: Sibi Sankar <[email protected]>
---
.../bindings/remoteproc/qcom,msm8996-mss-pil.yaml | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml
index d3d3fb2fe91d..ad1a51c23949 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml
@@ -123,6 +123,7 @@ properties:
items:
- description: MBA reserved region
- description: Modem reserved region
+ - description: Metadata reserved region

firmware-name:
$ref: /schemas/types.yaml#/definitions/string-array
@@ -165,6 +166,16 @@ properties:
- memory-region
deprecated: true

+ metadata:
+ type: object
+ description:
+ Metadata reserved region
+ properties:
+ memory-region: true
+ required:
+ - memory-region
+ deprecated: true
+
required:
- compatible
- reg
@@ -306,6 +317,7 @@ allOf:
- required:
- mba
- mpss
+ - metadata

additionalProperties: false

@@ -348,7 +360,7 @@ examples:
<&rpmhpd SDM845_MSS>;
power-domain-names = "cx", "mx", "mss";

- memory-region = <&mba_mem>, <&mpss_mem>;
+ memory-region = <&mba_mem>, <&mpss_mem>, <&mdata_mem>;

resets = <&aoss_reset AOSS_CC_MSS_RESTART>,
<&pdc_reset PDC_MODEM_SYNC_RESET>;
--
2.17.1

2023-01-10 10:07:33

by Krzysztof Kozlowski

Subject: Re: [PATCH V2 02/11] dt-bindings: remoteproc: qcom,msm8996-mss-pil: Update memory region

On 09/01/2023 04:48, Sibi Sankar wrote:
> The dynamic memory region used for metadata authentication would still
> be a part of the kernel mapping and any access to this region by the

Just one space before "by"

> application processor after assigning it to the remote Q6 will result
> in a XPU violation. This is fixed by using a no-map carveout instead.
> Update the bindings to reflect the addition of the new modem metadata
> carveout on MSM8996 (and similar) SoCs.
>
> Signed-off-by: Sibi Sankar <[email protected]>
> ---
> .../bindings/remoteproc/qcom,msm8996-mss-pil.yaml | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml
> index d3d3fb2fe91d..ad1a51c23949 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml
> @@ -123,6 +123,7 @@ properties:
> items:
> - description: MBA reserved region
> - description: Modem reserved region
> + - description: Metadata reserved region
>
> firmware-name:
> $ref: /schemas/types.yaml#/definitions/string-array
> @@ -165,6 +166,16 @@ properties:
> - memory-region
> deprecated: true
>
> + metadata:
> + type: object

addutionalProperties: false

> + description:
> + Metadata reserved region

Blank line

> + properties:
> + memory-region: true

Blank line

> + required:
> + - memory-region
> + deprecated: true


Best regards,
Krzysztof