2023-01-09 13:35:36

by Marcel Ziswiler

Subject: [PATCH v1 0/4] ARM/arm64: apalis/colibri-imx6/6ull/7/verdin-imx8mp: gpio-key node names

From: Marcel Ziswiler <[email protected]>


This series unifies/fixes wakeup gpio-key node names across all Toradex
modules. And yes, the Tegra-based Apalis/Colibri T20/T30/TK1 already
look good (;-p).


Marcel Ziswiler (4):
ARM: dts: colibri-imx6: improve wake-up with gpio key
ARM: dts: colibri-imx6ull: improve wake-up with gpio key
ARM: dts: apalis/colibri-imx6/6ull/7: proper gpio-key node names
arm64: dts: verdin-imx8mp: unify gpio-key node name

arch/arm/boot/dts/imx6qdl-apalis.dtsi | 2 +-
arch/arm/boot/dts/imx6qdl-colibri.dtsi | 4 ++--
arch/arm/boot/dts/imx6ull-colibri.dtsi | 4 ++--
arch/arm/boot/dts/imx7-colibri.dtsi | 2 +-
arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi | 2 +-
5 files changed, 7 insertions(+), 7 deletions(-)

--
2.35.1

2023-01-09 13:36:50

by Marcel Ziswiler

Subject: [PATCH v1 3/4] ARM: dts: apalis/colibri-imx6/6ull/7: proper gpio-key node names

From: Marcel Ziswiler <[email protected]>

The node names should be generic and DT schema expects certain pattern
(e.g. starting with key/button/switch).

Signed-off-by: Marcel Ziswiler <[email protected]>
---

arch/arm/boot/dts/imx6qdl-apalis.dtsi | 2 +-
arch/arm/boot/dts/imx6qdl-colibri.dtsi | 2 +-
arch/arm/boot/dts/imx6ull-colibri.dtsi | 2 +-
arch/arm/boot/dts/imx7-colibri.dtsi | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
index 7c17b91f0965..bb9aa5b7f03d 100644
--- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
@@ -41,7 +41,7 @@ gpio-keys {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_gpio_keys>;

- wakeup {
+ key-wakeup {
debounce-interval = <10>;
gpios = <&gpio1 4 GPIO_ACTIVE_LOW>;
label = "Wake-Up";
diff --git a/arch/arm/boot/dts/imx6qdl-colibri.dtsi b/arch/arm/boot/dts/imx6qdl-colibri.dtsi
index 9abce6bc6dd4..5c647339f8d0 100644
--- a/arch/arm/boot/dts/imx6qdl-colibri.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-colibri.dtsi
@@ -36,7 +36,7 @@ gpio-keys {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_gpio_keys>;

- wakeup {
+ key-wakeup {
debounce-interval = <10>;
gpios = <&gpio2 22 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>; /* SODIMM 45 */
label = "Wake-Up";
diff --git a/arch/arm/boot/dts/imx6ull-colibri.dtsi b/arch/arm/boot/dts/imx6ull-colibri.dtsi
index 368d11ae7a8a..bf64ba84b358 100644
--- a/arch/arm/boot/dts/imx6ull-colibri.dtsi
+++ b/arch/arm/boot/dts/imx6ull-colibri.dtsi
@@ -51,7 +51,7 @@ gpio-keys {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_snvs_gpiokeys>;

- wakeup {
+ key-wakeup {
debounce-interval = <10>;
gpios = <&gpio5 1 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>; /* SODIMM 45 */
label = "Wake-Up";
diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi b/arch/arm/boot/dts/imx7-colibri.dtsi
index f8b8372b6851..104580d51d74 100644
--- a/arch/arm/boot/dts/imx7-colibri.dtsi
+++ b/arch/arm/boot/dts/imx7-colibri.dtsi
@@ -39,7 +39,7 @@ gpio-keys {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_gpiokeys>;

- wakeup {
+ key-wakeup {
debounce-interval = <10>;
gpios = <&gpio1 1 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>; /* SODIMM 45 */
label = "Wake-Up";
--
2.35.1

2023-01-09 13:40:59

by Marcel Ziswiler

Subject: [PATCH v1 1/4] ARM: dts: colibri-imx6: improve wake-up with gpio key

From: Marcel Ziswiler <[email protected]>

The pin GPIO2_IO22 externally pulls down, it is required to sequentially
connect this pin (signal WAKE_MICO#) to +3v3 and then disconnect it to
trigger a wakeup interrupt.
Adding the flag GPIO_PULL_DOWN allows the system to be woken up just
connecting the pin GPIO2_IO22 to +3v3.

Signed-off-by: Marcel Ziswiler <[email protected]>
---

arch/arm/boot/dts/imx6qdl-colibri.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl-colibri.dtsi b/arch/arm/boot/dts/imx6qdl-colibri.dtsi
index d8f985f297e4..9abce6bc6dd4 100644
--- a/arch/arm/boot/dts/imx6qdl-colibri.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-colibri.dtsi
@@ -38,7 +38,7 @@ gpio-keys {

wakeup {
debounce-interval = <10>;
- gpios = <&gpio2 22 GPIO_ACTIVE_HIGH>; /* SODIMM 45 */
+ gpios = <&gpio2 22 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>; /* SODIMM 45 */
label = "Wake-Up";
linux,code = <KEY_WAKEUP>;
wakeup-source;
--
2.35.1

2023-01-09 13:53:34

by Marcel Ziswiler

Subject: [PATCH v1 2/4] ARM: dts: colibri-imx6ull: improve wake-up with gpio key

From: Marcel Ziswiler <[email protected]>

The pin GPIO5_IO01 externally pulls down, it is required to sequentially
connect this pin (signal WAKE_MICO#) to +3v3 and then disconnect it to
trigger a wakeup interrupt.
Adding the flag GPIO_PULL_DOWN allows the system to be woken up just
connecting the pin GPIO5_IO01 to +3v3.

Signed-off-by: Marcel Ziswiler <[email protected]>
---

arch/arm/boot/dts/imx6ull-colibri.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6ull-colibri.dtsi b/arch/arm/boot/dts/imx6ull-colibri.dtsi
index 336ab2e0534c..368d11ae7a8a 100644
--- a/arch/arm/boot/dts/imx6ull-colibri.dtsi
+++ b/arch/arm/boot/dts/imx6ull-colibri.dtsi
@@ -53,7 +53,7 @@ gpio-keys {

wakeup {
debounce-interval = <10>;
- gpios = <&gpio5 1 GPIO_ACTIVE_HIGH>; /* SODIMM 45 */
+ gpios = <&gpio5 1 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>; /* SODIMM 45 */
label = "Wake-Up";
linux,code = <KEY_WAKEUP>;
wakeup-source;
--
2.35.1

2023-01-26 00:28:24

by Shawn Guo

Subject: Re: [PATCH v1 0/4] ARM/arm64: apalis/colibri-imx6/6ull/7/verdin-imx8mp: gpio-key node names

On Mon, Jan 09, 2023 at 02:19:57PM +0100, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <[email protected]>
>
>
> This series unifies/fixes wakeup gpio-key node names across all Toradex
> modules. And yes, the Tegra-based Apalis/Colibri T20/T30/TK1 already
> look good (;-p).
>
>
> Marcel Ziswiler (4):
> ARM: dts: colibri-imx6: improve wake-up with gpio key
> ARM: dts: colibri-imx6ull: improve wake-up with gpio key
> ARM: dts: apalis/colibri-imx6/6ull/7: proper gpio-key node names
> arm64: dts: verdin-imx8mp: unify gpio-key node name

Applied all, thanks!