2023-01-10 04:00:27

by Hermes Zhang

[permalink] [raw]

Subject: [PATCH v2] power: supply: bq256xx: Init ichg/vbat value with chip default value

---

Init the ichg/vbat reg with chip default value instead of the max value
used now. The max value set in driver will result an unsafe case (e.g.
battery is over charging when in a hot environment) if no user space
update the value later.

Signed-off-by: Hermes Zhang <[email protected]>
---

Notes:
V2

drivers/power/supply/bq256xx_charger.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/power/supply/bq256xx_charger.c b/drivers/power/supply/bq256xx_charger.c
index 01ad84fd147c..6b5435bf2ed4 100644
--- a/drivers/power/supply/bq256xx_charger.c
+++ b/drivers/power/supply/bq256xx_charger.c
@@ -1563,7 +1563,7 @@ static int bq256xx_hw_init(struct bq256xx_device *bq)
return ret;

ret = bq->chip_info->bq256xx_set_ichg(bq,
- bat_info->constant_charge_current_max_ua);
+ bq->chip_info->bq256xx_def_ichg);
if (ret)
return ret;

@@ -1573,7 +1573,7 @@ static int bq256xx_hw_init(struct bq256xx_device *bq)
return ret;

ret = bq->chip_info->bq256xx_set_vbatreg(bq,
- bat_info->constant_charge_voltage_max_uv);
+ bq->chip_info->bq256xx_def_vbatreg);
if (ret)
return ret;

--
2.30.2

2023-02-03 12:34:37

by Sebastian Reichel

[permalink] [raw]

Subject: Re: [PATCH v2] power: supply: bq256xx: Init ichg/vbat value with chip default value

---

Hi,

On Tue, Jan 10, 2023 at 10:47:46AM +0800, Hermes Zhang wrote:
> Init the ichg/vbat reg with chip default value instead of the max value
> used now. The max value set in driver will result an unsafe case (e.g.
> battery is over charging when in a hot environment) if no user space
> update the value later.
>
> Signed-off-by: Hermes Zhang <[email protected]>
> ---

Thanks, queued.

-- Sebastian

>
> Notes:
> V2
>
> drivers/power/supply/bq256xx_charger.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/power/supply/bq256xx_charger.c b/drivers/power/supply/bq256xx_charger.c
> index 01ad84fd147c..6b5435bf2ed4 100644
> --- a/drivers/power/supply/bq256xx_charger.c
> +++ b/drivers/power/supply/bq256xx_charger.c
> @@ -1563,7 +1563,7 @@ static int bq256xx_hw_init(struct bq256xx_device *bq)
> return ret;
>
> ret = bq->chip_info->bq256xx_set_ichg(bq,
> - bat_info->constant_charge_current_max_ua);
> + bq->chip_info->bq256xx_def_ichg);
> if (ret)
> return ret;
>
> @@ -1573,7 +1573,7 @@ static int bq256xx_hw_init(struct bq256xx_device *bq)
> return ret;
>
> ret = bq->chip_info->bq256xx_set_vbatreg(bq,
> - bat_info->constant_charge_voltage_max_uv);
> + bq->chip_info->bq256xx_def_vbatreg);
> if (ret)
> return ret;
>
> --
> 2.30.2
>

---

Attachments:

(No filename) (1.29 kB)
signature.asc (833.00 B)
Download all attachments