2023-01-11 19:19:32

by Keith Busch

Subject: [PATCH] caif: don't assume iov_iter type

From: Keith Busch <[email protected]>

The details of the iov_iter types are appropriately abstracted, so
there's no need to check for specific type fields. Just let the
abstractions handle it.

This is preparing for io_uring/net's io_send to utilize the more
efficient ITER_UBUF.

Signed-off-by: Keith Busch <[email protected]>
---
net/caif/caif_socket.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/net/caif/caif_socket.c b/net/caif/caif_socket.c
index 748be72532485..1f2c1d7b90e23 100644
--- a/net/caif/caif_socket.c
+++ b/net/caif/caif_socket.c
@@ -533,10 +533,6 @@ static int caif_seqpkt_sendmsg(struct socket *sock, struct msghdr *msg,
if (msg->msg_namelen)
goto err;

- ret = -EINVAL;
- if (unlikely(msg->msg_iter.nr_segs == 0) ||
- unlikely(msg->msg_iter.iov->iov_base == NULL))
- goto err;
noblock = msg->msg_flags & MSG_DONTWAIT;

timeo = sock_sndtimeo(sk, noblock);
--
2.30.2

2023-01-11 22:36:39

by Jens Axboe

Subject: Re: [PATCH] caif: don't assume iov_iter type

On 1/11/23 11:42 AM, Keith Busch wrote:
> From: Keith Busch <[email protected]>
>
> The details of the iov_iter types are appropriately abstracted, so
> there's no need to check for specific type fields. Just let the
> abstractions handle it.
>
> This is preparing for io_uring/net's io_send to utilize the more
> efficient ITER_UBUF.

Looks good to me - the correct return here would be -EFAULT as well,
not -EINVAL. Which is what will happen once memcpy_from_msg() is
called anyway.

Reviewed-by: Jens Axboe <[email protected]>

--
Jens Axboe

2023-01-14 05:27:09

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] caif: don't assume iov_iter type

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <[email protected]>:

On Wed, 11 Jan 2023 10:42:45 -0800 you wrote:
> From: Keith Busch <[email protected]>
>
> The details of the iov_iter types are appropriately abstracted, so
> there's no need to check for specific type fields. Just let the
> abstractions handle it.
>
> This is preparing for io_uring/net's io_send to utilize the more
> efficient ITER_UBUF.
>
> [...]

Here is the summary with links:
- caif: don't assume iov_iter type
https://git.kernel.org/netdev/net-next/c/c19175141079

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html