2023-01-11 21:18:03

by Martin Blumenstingl

[permalink] [raw]
Subject: [PATCH v2 4/6] arm64: dts: meson-gx: Fix Ethernet MAC address unit name

Unit names should use hyphens instead of underscores to not cause
warnings.

Fixes: bfe59f92d306 ("ARM64: dts: amlogic: gxbb: Enable NVMEM")
Suggested-by: Vyacheslav Bocharov <[email protected]>
Signed-off-by: Martin Blumenstingl <[email protected]>
---
changes from v1 -> v2:
- new patch

arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
index e3c12e0be99d..f8b115cd6775 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
@@ -233,7 +233,7 @@ sn: sn@14 {
reg = <0x14 0x10>;
};

- eth_mac: eth_mac@34 {
+ eth_mac: eth-mac@34 {
reg = <0x34 0x10>;
};

--
2.39.0


2023-01-13 08:14:48

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH v2 4/6] arm64: dts: meson-gx: Fix Ethernet MAC address unit name

On 11/01/2023 22:13, Martin Blumenstingl wrote:
> Unit names should use hyphens instead of underscores to not cause
> warnings.
>
> Fixes: bfe59f92d306 ("ARM64: dts: amlogic: gxbb: Enable NVMEM")
> Suggested-by: Vyacheslav Bocharov <[email protected]>
> Signed-off-by: Martin Blumenstingl <[email protected]>
> ---
> changes from v1 -> v2:
> - new patch
>
> arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> index e3c12e0be99d..f8b115cd6775 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> @@ -233,7 +233,7 @@ sn: sn@14 {
> reg = <0x14 0x10>;
> };
>
> - eth_mac: eth_mac@34 {
> + eth_mac: eth-mac@34 {
> reg = <0x34 0x10>;
> };
>

2023-01-13 08:23:41

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH v2 4/6] arm64: dts: meson-gx: Fix Ethernet MAC address unit name

On 11/01/2023 22:13, Martin Blumenstingl wrote:
> Unit names should use hyphens instead of underscores to not cause
> warnings.
>
> Fixes: bfe59f92d306 ("ARM64: dts: amlogic: gxbb: Enable NVMEM")
> Suggested-by: Vyacheslav Bocharov <[email protected]>
> Signed-off-by: Martin Blumenstingl <[email protected]>
> ---
> changes from v1 -> v2:
> - new patch
>
> arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> index e3c12e0be99d..f8b115cd6775 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> @@ -233,7 +233,7 @@ sn: sn@14 {
> reg = <0x14 0x10>;
> };
>
> - eth_mac: eth_mac@34 {
> + eth_mac: eth-mac@34 {
> reg = <0x34 0x10>;
> };
>

Reviewed-by: Neil Armstrong <[email protected]>