2023-01-13 18:00:38

by Bastian Krause

[permalink] [raw]
Subject: [PATCH 1/2] dt-bindings: reset: imx-src: add syscon and simple-mfd compatibles

This allows passing the reboot mode from the OS to the bootloader via the
syscon-reboot-mode binding. Add a "simple-mfd" to support probing such a
child node. The actual reboot mode node could then be defined in a
board device-tree or fixed up by the bootloader.

Suggested-by: Ahmad Fatoum <[email protected]>
Signed-off-by: Bastian Krause <[email protected]>
---
Documentation/devicetree/bindings/reset/fsl,imx-src.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml b/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml
index b11ac533f914c..9ec734e14e9f5 100644
--- a/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml
+++ b/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml
@@ -38,6 +38,8 @@ properties:
- items:
- const: "fsl,imx6q-src"
- const: "fsl,imx51-src"
+ - const: "syscon"
+ - const: "simple-mfd"
- items:
- const: "fsl,imx6sx-src"
- const: "fsl,imx51-src"

--
2.30.2


2023-01-16 09:28:37

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: reset: imx-src: add syscon and simple-mfd compatibles

On 13/01/2023 18:32, Bastian Krause wrote:
> This allows passing the reboot mode from the OS to the bootloader via the
> syscon-reboot-mode binding. Add a "simple-mfd" to support probing such a
> child node. The actual reboot mode node could then be defined in a
> board device-tree or fixed up by the bootloader.
>
> Suggested-by: Ahmad Fatoum <[email protected]>
> Signed-off-by: Bastian Krause <[email protected]>
> ---
> Documentation/devicetree/bindings/reset/fsl,imx-src.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml b/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml
> index b11ac533f914c..9ec734e14e9f5 100644
> --- a/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml
> +++ b/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml
> @@ -38,6 +38,8 @@ properties:
> - items:
> - const: "fsl,imx6q-src"
> - const: "fsl,imx51-src"
> + - const: "syscon"
> + - const: "simple-mfd"

1. Why only this variant can be used as suscon-reboot-mode and not others?

2. Drop quotes. In a follow up patch you can also remove quotes from
other compatibles.


Best regards,
Krzysztof

2023-01-16 09:28:38

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: reset: imx-src: add syscon and simple-mfd compatibles

On 13/01/2023 18:32, Bastian Krause wrote:
> This allows passing the reboot mode from the OS to the bootloader via the
> syscon-reboot-mode binding. Add a "simple-mfd" to support probing such a
> child node. The actual reboot mode node could then be defined in a
> board device-tree or fixed up by the bootloader.
>
> Suggested-by: Ahmad Fatoum <[email protected]>
> Signed-off-by: Bastian Krause <[email protected]>
> ---
> Documentation/devicetree/bindings/reset/fsl,imx-src.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml b/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml
> index b11ac533f914c..9ec734e14e9f5 100644
> --- a/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml
> +++ b/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml
> @@ -38,6 +38,8 @@ properties:
> - items:
> - const: "fsl,imx6q-src"
> - const: "fsl,imx51-src"
> + - const: "syscon"
> + - const: "simple-mfd"

This is not sufficient. You can easily check it by yourself - add
syscon-reboot-mode node and run dtbs_check.

Best regards,
Krzysztof