2023-01-13 13:35:39

by Lucas Tanure

Subject: [PATCH] arm64: dts: rockchip: Fix RX delay for ethernet phy

Add network PHY rx delay and change type to rgmii, so
that it is applied. This fixes packet loss when more
than a few packets are exchanged.

Fixes: 55fa4c2a7a912 ("arm64: dts: rockchip: Add rock-5a board")
Signed-off-by: Lucas Tanure <[email protected]>
---
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
index cc4c68936b3a..9e22ce01e1a3 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
@@ -53,7 +53,7 @@ vcc_1v1_nldo_s3: vcc-1v1-nldo-s3 {
&gmac1 {
clock_in_out = "output";
phy-handle = <&rgmii_phy1>;
- phy-mode = "rgmii-rxid";
+ phy-mode = "rgmii";
pinctrl-0 = <&gmac1_miim
&gmac1_tx_bus2
&gmac1_rx_bus2
@@ -61,6 +61,7 @@ &gmac1_rgmii_clk
&gmac1_rgmii_bus>;
pinctrl-names = "default";
tx_delay = <0x3a>;
+ rx_delay = <0x3e>;
status = "okay";
};

--
2.39.0

2023-01-15 14:56:26

by Heiko Stuebner

Subject: Re: [PATCH] arm64: dts: rockchip: Fix RX delay for ethernet phy

On Fri, 13 Jan 2023 13:02:20 +0000, Lucas Tanure wrote:
> Add network PHY rx delay and change type to rgmii, so
> that it is applied. This fixes packet loss when more
> than a few packets are exchanged.
>
>

Applied, thanks!

[1/1] arm64: dts: rockchip: Fix RX delay for ethernet phy
commit: 0b86f9570e7713faaa32f2775eb04021d1213018

Best regards,
--
Heiko Stuebner <[email protected]>