2023-01-13 14:25:44

by Lukas Czerner

[permalink] [raw]
Subject: ll_rw_block() funcation has been removed

Hi,

ll_rw_block() has been removed with commit 79f597842069 ("fs/buffer:
remove ll_rw_block() helper"), but I noticed that it's still beeing
referenced in drivers/misc/lkdtm/core.c. I know nothing about LKDTM so I
can't even tell whether it's a problem at all, but I though it's worth
letting you know.

Best regards,
-Lukas


2023-01-13 23:31:47

by Kees Cook

[permalink] [raw]
Subject: Re: ll_rw_block() funcation has been removed

On Fri, Jan 13, 2023 at 02:38:43PM +0100, Lukas Czerner wrote:
> Hi,
>
> ll_rw_block() has been removed with commit 79f597842069 ("fs/buffer:
> remove ll_rw_block() helper"), but I noticed that it's still beeing
> referenced in drivers/misc/lkdtm/core.c. I know nothing about LKDTM so I
> can't even tell whether it's a problem at all, but I though it's worth
> letting you know.

Ah-ha! Thanks. Yeah, lkdtm just has a predefined set of possible
breakpoints. I can either remove this or add something similar. Any
suggestion? (Or a patch?)

-Kees

--
Kees Cook