2023-01-13 19:26:58

by Joerg Roedel

Subject: [PATCH] iommu/fsl_pamu: Fix compile error after adding set_platform_dma_ops

From: Joerg Roedel <[email protected]>

The struct initializer for set_platform_dma_ops uses a semicolon as
separator where a comma is required. Fix the compile error by using the
correct separator.

Fixes: c1fe9119ee70 ("iommu: Add set_platform_dma_ops callbacks")
Signed-off-by: Joerg Roedel <[email protected]>
---
drivers/iommu/fsl_pamu_domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/fsl_pamu_domain.c b/drivers/iommu/fsl_pamu_domain.c
index e123161c211a..bce372297099 100644
--- a/drivers/iommu/fsl_pamu_domain.c
+++ b/drivers/iommu/fsl_pamu_domain.c
@@ -452,7 +452,7 @@ static const struct iommu_ops fsl_pamu_ops = {
.domain_alloc = fsl_pamu_domain_alloc,
.probe_device = fsl_pamu_probe_device,
.device_group = fsl_pamu_device_group,
- .set_platform_dma_ops = fsl_pamu_set_platform_dma;
+ .set_platform_dma_ops = fsl_pamu_set_platform_dma,
.default_domain_ops = &(const struct iommu_domain_ops) {
.attach_dev = fsl_pamu_attach_device,
.iova_to_phys = fsl_pamu_iova_to_phys,
--
2.39.0

2023-01-13 20:32:03

by Jason Gunthorpe

Subject: Re: [PATCH] iommu/fsl_pamu: Fix compile error after adding set_platform_dma_ops

On Fri, Jan 13, 2023 at 08:15:28PM +0100, Joerg Roedel wrote:
> From: Joerg Roedel <[email protected]>
>
> The struct initializer for set_platform_dma_ops uses a semicolon as
> separator where a comma is required. Fix the compile error by using the
> correct separator.
>
> Fixes: c1fe9119ee70 ("iommu: Add set_platform_dma_ops callbacks")
> Signed-off-by: Joerg Roedel <[email protected]>
> ---
> drivers/iommu/fsl_pamu_domain.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Jason Gunthorpe <[email protected]>

I'd probably just squash these :\

Jason