2023-01-13 21:10:42

by Stephen Boyd

[permalink] [raw]
Subject: [PATCH 5.15.y v2 0/5] phy: qcom-qmp-combo: Backport some stable fixes

After the qmp phy driver was split it looks like 5.15.y stable kernels
aren't getting fixes like commit 7a7d86d14d07 ("phy: qcom-qmp-combo: fix
broken power on") which is tagged for stable 5.10. Trogdor boards use
the qmp phy on 5.15.y kernels, so I backported the fixes I could find
that looked like we may possibly trip over at some point.

USB and DP work on my Trogdor.Lazor board with this set.

Changes from v1 (https://lore.kernel.org/r/[email protected]):
* New patch for memleak on probe deferal to avoid compat issues
* Update "fix broken power on" patch for pcie/ufs phy

Johan Hovold (5):
phy: qcom-qmp-combo: disable runtime PM on unbind
phy: qcom-qmp-combo: fix memleak on probe deferral
phy: qcom-qmp-usb: fix memleak on probe deferral
phy: qcom-qmp-combo: fix broken power on
phy: qcom-qmp-combo: fix runtime suspend

drivers/phy/qualcomm/phy-qcom-qmp.c | 97 ++++++++++++++++++-----------
1 file changed, 61 insertions(+), 36 deletions(-)

Cc: Johan Hovold <[email protected]>
Cc: Dmitry Baryshkov <[email protected]>
Cc: Vinod Koul <[email protected]>

base-commit: d57287729e229188e7d07ef0117fe927664e08cb
--
https://chromeos.dev


2023-01-22 14:23:32

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 5.15.y v2 0/5] phy: qcom-qmp-combo: Backport some stable fixes

On Fri, Jan 13, 2023 at 12:45:43PM -0800, Stephen Boyd wrote:
> After the qmp phy driver was split it looks like 5.15.y stable kernels
> aren't getting fixes like commit 7a7d86d14d07 ("phy: qcom-qmp-combo: fix
> broken power on") which is tagged for stable 5.10. Trogdor boards use
> the qmp phy on 5.15.y kernels, so I backported the fixes I could find
> that looked like we may possibly trip over at some point.
>
> USB and DP work on my Trogdor.Lazor board with this set.
>
> Changes from v1 (https://lore.kernel.org/r/[email protected]):
> * New patch for memleak on probe deferal to avoid compat issues
> * Update "fix broken power on" patch for pcie/ufs phy
>
> Johan Hovold (5):
> phy: qcom-qmp-combo: disable runtime PM on unbind
> phy: qcom-qmp-combo: fix memleak on probe deferral
> phy: qcom-qmp-usb: fix memleak on probe deferral
> phy: qcom-qmp-combo: fix broken power on
> phy: qcom-qmp-combo: fix runtime suspend
>
> drivers/phy/qualcomm/phy-qcom-qmp.c | 97 ++++++++++++++++++-----------
> 1 file changed, 61 insertions(+), 36 deletions(-)
>
> Cc: Johan Hovold <[email protected]>
> Cc: Dmitry Baryshkov <[email protected]>
> Cc: Vinod Koul <[email protected]>
>
> base-commit: d57287729e229188e7d07ef0117fe927664e08cb
> --
> https://chromeos.dev
>

For obvious reasons, I can't take this series if newer kernel releases
do not also contain all of these (no would you want me to.)

So can you please also provide a backported series for 6.1.y so that
these can be considered?

thanks,

greg k-h

2023-02-02 22:27:15

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH 5.15.y v2 0/5] phy: qcom-qmp-combo: Backport some stable fixes

Quoting Greg KH (2023-01-22 06:23:25)
> On Fri, Jan 13, 2023 at 12:45:43PM -0800, Stephen Boyd wrote:
> > After the qmp phy driver was split it looks like 5.15.y stable kernels
> > aren't getting fixes like commit 7a7d86d14d07 ("phy: qcom-qmp-combo: fix
> > broken power on") which is tagged for stable 5.10. Trogdor boards use
> > the qmp phy on 5.15.y kernels, so I backported the fixes I could find
> > that looked like we may possibly trip over at some point.
> >
> > USB and DP work on my Trogdor.Lazor board with this set.
> >
> > Changes from v1 (https://lore.kernel.org/r/[email protected]):
> > * New patch for memleak on probe deferal to avoid compat issues
> > * Update "fix broken power on" patch for pcie/ufs phy
> >
> > Johan Hovold (5):
> > phy: qcom-qmp-combo: disable runtime PM on unbind
> > phy: qcom-qmp-combo: fix memleak on probe deferral
> > phy: qcom-qmp-usb: fix memleak on probe deferral
> > phy: qcom-qmp-combo: fix broken power on
> > phy: qcom-qmp-combo: fix runtime suspend
> >
> > drivers/phy/qualcomm/phy-qcom-qmp.c | 97 ++++++++++++++++++-----------
> > 1 file changed, 61 insertions(+), 36 deletions(-)
> >
> > Cc: Johan Hovold <[email protected]>
> > Cc: Dmitry Baryshkov <[email protected]>
> > Cc: Vinod Koul <[email protected]>
> >
> > base-commit: d57287729e229188e7d07ef0117fe927664e08cb
> > --
> > https://chromeos.dev
> >
>
> For obvious reasons, I can't take this series if newer kernel releases
> do not also contain all of these (no would you want me to.)
>
> So can you please also provide a backported series for 6.1.y so that
> these can be considered?

Sure. All of the patches have been applied to 6.1.y except for the last
one, which picks cleanly, c7b98de745cf ("phy: qcom-qmp-combo: fix
runtime suspend"). I can send that over.