Changes since v1:
- move 16-bit brightness handling to new functions and revert API
change (1/2)
- remove Change-Id in compliance with checkpatch.pl (1/2)
- separate panel driver changes (2/2)
This series adds proper support for 16-bit MIPI DSI brightness and
cleans up existing panel drivers.
I cannot test the SOFEF00 change, although I tested an equivalent change
to an external S6E3FA7 driver generated with the same generator. Both
setting and getting works on S6E3FA7.
Daniel Mentz (1):
drm/dsi-mipi: Fix byte order of DCS set/get brightness
Richard Acayan (1):
drm/panel: sofef00: Use 16-bit panel brightness
drivers/gpu/drm/drm_mipi_dsi.c | 52 +++++++++++++++++++
drivers/gpu/drm/panel/panel-samsung-sofef00.c | 9 +---
include/drm/drm_mipi_dsi.h | 4 ++
3 files changed, 58 insertions(+), 7 deletions(-)
--
2.39.0
These panels communicate brightness in big endian. This is not a quirk
of the panels themselves, but rather, a part of the MIPI standard. Use
the new mipi_dsi_dcs_set_display_brightness_wide() function that
properly handles 16-bit brightness instead of doing special processing
of the brightness values.
Signed-off-by: Richard Acayan <[email protected]>
---
drivers/gpu/drm/panel/panel-samsung-sofef00.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/drm/panel/panel-samsung-sofef00.c
index 1a0d24595faa..014fe350bc59 100644
--- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c
+++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c
@@ -10,7 +10,6 @@
#include <linux/of.h>
#include <linux/of_device.h>
#include <linux/regulator/consumer.h>
-#include <linux/swab.h>
#include <linux/backlight.h>
#include <video/mipi_display.h>
@@ -221,13 +220,9 @@ static int sofef00_panel_bl_update_status(struct backlight_device *bl)
{
struct mipi_dsi_device *dsi = bl_get_data(bl);
int err;
- u16 brightness;
+ u16 brightness = (u16)backlight_get_brightness(bl);
- brightness = (u16)backlight_get_brightness(bl);
- // This panel needs the high and low bytes swapped for the brightness value
- brightness = __swab16(brightness);
-
- err = mipi_dsi_dcs_set_display_brightness(dsi, brightness);
+ err = mipi_dsi_dcs_set_display_brightness_large(dsi, brightness);
if (err < 0)
return err;
--
2.39.0