2023-01-16 07:32:23

by Sinthu Raja

[permalink] [raw]
Subject: [PATCH V5 0/3] AM68 SK: Add initial support

From: Sinthu Raja <[email protected]>

Hi All,
This series of patches add support for AM68 Starter kit(SK). AM68 SK
is a low cost, small form factor board designed for TI’s AM68 SoC.

Refer below link to AM68 Technical Reference Manual for further details:
http://www.ti.com/lit/pdf/spruj28

Design files can be referrred from https://www.ti.com/lit/zip/SPRR463

Changes in V5:
=============
Address review comments:
- Remove the unessential comment.
- Remove alignment property from secure-ddr node, as no memory is allocated out
of this region.

Changes in V4:
=============
Repost after rebasing to 6.2 rc1

Changes in V3:
==============
Address all the review comments and the changes are captured in separate patches.
- Remove the unused nodes that are disabled by default.
- Update the gpio regulator node: gpio-regulator-tlv to "regulator-tlv".

V1: https://lore.kernel.org/linux-arm-kernel/[email protected]/t/#mbe43b02221733bb6eb06b203359e90ec08406afc
V2: https://lore.kernel.org/lkml/[email protected]/
V3: https://lore.kernel.org/lkml/[email protected]/
V4: https://lore.kernel.org/lkml/[email protected]/

Sinthu Raja (3):
dt-bindings: arm: ti: Add binding for AM68 SK
arm64: dts: ti: Add initial support for AM68 SK System on Module
arm64: dts: ti: k3-am68-sk: Add support for AM68 SK base board

.../devicetree/bindings/arm/ti/k3.yaml | 1 +
arch/arm64/boot/dts/ti/Makefile | 2 +
.../boot/dts/ti/k3-am68-sk-base-board.dts | 335 ++++++++++++++++++
arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi | 29 ++
4 files changed, 367 insertions(+)
create mode 100644 arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
create mode 100644 arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi

--
2.36.1


2023-01-16 07:35:36

by Sinthu Raja

[permalink] [raw]
Subject: [PATCH V5 2/3] arm64: dts: ti: Add initial support for AM68 SK System on Module

From: Sinthu Raja <[email protected]>

AM68 Starter Kit (SK) is a low cost, small form factor board designed
for TI’s AM68 SoC. TI’s AM68 SoC comprises of dual core A72, high
performance vision accelerators, hardware accelerators, latest C71x
DSP, high bandwidth real-time IPs for capture and display. The SoC is
power optimized to provide best in class performance for industrial
applications.

AM68 SK supports the following interfaces:
* 16 GB LPDDR4 RAM
* x1 Gigabit Ethernet interface
* x1 USB 3.1 Type-C port
* x2 USB 3.1 Type-A ports
* x1 PCIe M.2 M Key
* 512 Mbit OSPI flash
* x2 CSI2 Camera interface (RPi and TI Camera connector)
* 40-pin Raspberry Pi GPIO header

SK's System on Module (SoM) contains the SoC and DDR.
Therefore, add DT node for the SOC and DDR on the SoM.

Schematics: https://www.ti.com/lit/zip/SPRR463
TRM: http://www.ti.com/lit/pdf/spruj28

Signed-off-by: Sinthu Raja <[email protected]>
---

Changes in V5:
=============
Address review comments:
- Remove the unessential comment.
- Remove alignment property from secure-ddr node, as no memory is allocated out
of this region.

No changes in V4.

Changes in V3:
=============
Addressed review comments
- Removed the unused nodes that are disabled by default.
OSPI support will be added once the OSPI node is enabled for J721s2/AM68 in main DTSI.

Changes in V2:
=============
Address review comments
- drop the empty lines.

V1: https://lore.kernel.org/linux-arm-kernel/[email protected]/
V2: https://lore.kernel.org/lkml/[email protected]/
V3: https://lore.kernel.org/lkml/[email protected]/
V4: https://lore.kernel.org/lkml/[email protected]/

arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi | 29 ++++++++++++++++++++++
1 file changed, 29 insertions(+)
create mode 100644 arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi

diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi b/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi
new file mode 100644
index 000000000000..e92431250729
--- /dev/null
+++ b/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi
@@ -0,0 +1,29 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
+ */
+
+/dts-v1/;
+
+#include "k3-j721s2.dtsi"
+#include <dt-bindings/gpio/gpio.h>
+
+/ {
+ memory@80000000 {
+ device_type = "memory";
+ /* 16 GB RAM */
+ reg = <0x00 0x80000000 0x00 0x80000000>,
+ <0x08 0x80000000 0x03 0x80000000>;
+ };
+
+ reserved_memory: reserved-memory {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
+
+ secure_ddr: optee@9e800000 {
+ reg = <0x00 0x9e800000 0x00 0x01800000>;
+ no-map;
+ };
+ };
+};
--
2.36.1

2023-01-16 11:34:18

by Neha Malcom Francis

[permalink] [raw]
Subject: Re: [PATCH V5 0/3] AM68 SK: Add initial support

Hi Sinthu

On 16/01/23 12:44, Sinthu Raja wrote:
> From: Sinthu Raja <[email protected]>
>
> Hi All,
> This series of patches add support for AM68 Starter kit(SK). AM68 SK
> is a low cost, small form factor board designed for TI’s AM68 SoC.
>
> Refer below link to AM68 Technical Reference Manual for further details:
> http://www.ti.com/lit/pdf/spruj28
>
> Design files can be referrred from https://www.ti.com/lit/zip/SPRR463
>
> Changes in V5:
> =============
> Address review comments:
> - Remove the unessential comment.
> - Remove alignment property from secure-ddr node, as no memory is allocated out
> of this region.
>
> Changes in V4:
> =============
> Repost after rebasing to 6.2 rc1
>
> Changes in V3:
> ==============
> Address all the review comments and the changes are captured in separate patches.
> - Remove the unused nodes that are disabled by default.
> - Update the gpio regulator node: gpio-regulator-tlv to "regulator-tlv".
>
> V1: https://lore.kernel.org/linux-arm-kernel/[email protected]/t/#mbe43b02221733bb6eb06b203359e90ec08406afc
> V2: https://lore.kernel.org/lkml/[email protected]/
> V3: https://lore.kernel.org/lkml/[email protected]/
> V4: https://lore.kernel.org/lkml/[email protected]/
>
> Sinthu Raja (3):
> dt-bindings: arm: ti: Add binding for AM68 SK
> arm64: dts: ti: Add initial support for AM68 SK System on Module
> arm64: dts: ti: k3-am68-sk: Add support for AM68 SK base board
>
> .../devicetree/bindings/arm/ti/k3.yaml | 1 +
> arch/arm64/boot/dts/ti/Makefile | 2 +
> .../boot/dts/ti/k3-am68-sk-base-board.dts | 335 ++++++++++++++++++
> arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi | 29 ++
> 4 files changed, 367 insertions(+)
> create mode 100644 arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> create mode 100644 arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi
>

For the series:

Reviewed-by: Neha Malcom Francis <[email protected]>

--
Thanking You
Neha Malcom Francis

2023-01-16 14:45:36

by Vaishnav Achath

[permalink] [raw]
Subject: Re: [PATCH V5 2/3] arm64: dts: ti: Add initial support for AM68 SK System on Module

Hi Sinthu,

On 16/01/23 12:44, Sinthu Raja wrote:
> From: Sinthu Raja <[email protected]>
>
> AM68 Starter Kit (SK) is a low cost, small form factor board designed
> for TI’s AM68 SoC. TI’s AM68 SoC comprises of dual core A72, high
> performance vision accelerators, hardware accelerators, latest C71x
> DSP, high bandwidth real-time IPs for capture and display. The SoC is
> power optimized to provide best in class performance for industrial
> applications.
>
> AM68 SK supports the following interfaces:
> * 16 GB LPDDR4 RAM
> * x1 Gigabit Ethernet interface
> * x1 USB 3.1 Type-C port
> * x2 USB 3.1 Type-A ports
> * x1 PCIe M.2 M Key
> * 512 Mbit OSPI flash
> * x2 CSI2 Camera interface (RPi and TI Camera connector)
> * 40-pin Raspberry Pi GPIO header
>
> SK's System on Module (SoM) contains the SoC and DDR.
> Therefore, add DT node for the SOC and DDR on the SoM.
>
> Schematics: https://www.ti.com/lit/zip/SPRR463
> TRM: http://www.ti.com/lit/pdf/spruj28
>
> Signed-off-by: Sinthu Raja <[email protected]>
> ---
>
> Changes in V5:
> =============
> Address review comments:
> - Remove the unessential comment.
> - Remove alignment property from secure-ddr node, as no memory is allocated out
> of this region.
>
> No changes in V4.
>
> Changes in V3:
> =============
> Addressed review comments
> - Removed the unused nodes that are disabled by default.
> OSPI support will be added once the OSPI node is enabled for J721s2/AM68 in main DTSI.
>
> Changes in V2:
> =============
> Address review comments
> - drop the empty lines.
>
> V1: https://lore.kernel.org/linux-arm-kernel/[email protected]/
> V2: https://lore.kernel.org/lkml/[email protected]/
> V3: https://lore.kernel.org/lkml/[email protected]/
> V4: https://lore.kernel.org/lkml/[email protected]/
>
> arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi | 29 ++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
> create mode 100644 arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi b/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi
> new file mode 100644
> index 000000000000..e92431250729
> --- /dev/null
> +++ b/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi
> @@ -0,0 +1,29 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
> + */
> +
> +/dts-v1/;
> +
> +#include "k3-j721s2.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
> +
> +/ {
> + memory@80000000 {
> + device_type = "memory";
> + /* 16 GB RAM */
> + reg = <0x00 0x80000000 0x00 0x80000000>,
> + <0x08 0x80000000 0x03 0x80000000>;
> + };
> +
> + reserved_memory: reserved-memory {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + secure_ddr: optee@9e800000 {
> + reg = <0x00 0x9e800000 0x00 0x01800000>;
> + no-map;
> + };
> + };

Thank you for making the updates,

Tested-by: Vaishnav Achath <[email protected]>

Bootlogs during my testing :
https://gist.github.com/vaishnavachath/64b58be41028c646b06568a73faed2fd

> +};

--
Regards,
Vaishnav

2023-01-23 17:40:29

by Vignesh Raghavendra

[permalink] [raw]
Subject: Re: [PATCH V5 0/3] AM68 SK: Add initial support

Hi Sinthu Raja,

On Mon, 16 Jan 2023 12:44:43 +0530, Sinthu Raja wrote:
> From: Sinthu Raja <[email protected]>
>
> Hi All,
> This series of patches add support for AM68 Starter kit(SK). AM68 SK
> is a low cost, small form factor board designed for TI’s AM68 SoC.
>
> Refer below link to AM68 Technical Reference Manual for further details:
> http://www.ti.com/lit/pdf/spruj28
>
> [...]

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[1/3] dt-bindings: arm: ti: Add binding for AM68 SK
commit: 73b1c4f5f53e531f75d4b65dec4784cf67e685f2
[2/3] arm64: dts: ti: Add initial support for AM68 SK System on Module
commit: 2b6277b76d42cbb781c558ea982e23cd770dd363
[3/3] arm64: dts: ti: k3-am68-sk: Add support for AM68 SK base board
commit: a266c180b398eab5030bdcf2d1bbdc62fb7fc9c1

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Vignesh