2023-01-16 19:27:21

by Brent Pappas

Subject: [PATCH] staging: greybus: gpio: Replace macro irq_data_to_gpio_chip with function

Replace the macro irq_data_to_gpio_chip with a static inline function to comply
with Linux coding style standards.

Signed-off-by: Brent Pappas <[email protected]>
---
drivers/staging/greybus/gpio.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging/greybus/gpio.c
index 8a7cf1d0e968..833162ceb385 100644
--- a/drivers/staging/greybus/gpio.c
+++ b/drivers/staging/greybus/gpio.c
@@ -43,7 +43,11 @@ struct gb_gpio_controller {
};
#define gpio_chip_to_gb_gpio_controller(chip) \
container_of(chip, struct gb_gpio_controller, chip)
-#define irq_data_to_gpio_chip(d) (d->domain->host_data)
+
+static inline void *irq_data_to_gpio_chip(struct irq_data *d)
+{
+ return d->domain->host_data;
+}

static int gb_gpio_line_count_operation(struct gb_gpio_controller *ggc)
{
--
2.34.1

2023-01-17 09:14:28

by Dan Carpenter

Subject: Re: [PATCH] staging: greybus: gpio: Replace macro irq_data_to_gpio_chip with function

On Mon, Jan 16, 2023 at 01:47:06PM -0500, Brent Pappas wrote:
> Replace the macro irq_data_to_gpio_chip with a static inline function to comply
> with Linux coding style standards.
>
> Signed-off-by: Brent Pappas <[email protected]>
> ---
> drivers/staging/greybus/gpio.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging/greybus/gpio.c
> index 8a7cf1d0e968..833162ceb385 100644
> --- a/drivers/staging/greybus/gpio.c
> +++ b/drivers/staging/greybus/gpio.c
> @@ -43,7 +43,11 @@ struct gb_gpio_controller {
> };
> #define gpio_chip_to_gb_gpio_controller(chip) \
> container_of(chip, struct gb_gpio_controller, chip)
> -#define irq_data_to_gpio_chip(d) (d->domain->host_data)
> +
> +static inline void *irq_data_to_gpio_chip(struct irq_data *d)

1) Don't make this a void pointer. ->host_data is void but we want to
return a struct gpio_chip * type so declare it as returning a
gpio_chip struct pointer. A big advantage of function over macros is
the type checking.

2) Don't declare it as inline. Modern compilers are smart and confident.
They are smart enough to make it inline automatically. And confident
enough that they just ignore when people mark stuff as inline. (We
have an __always_inline macro for when the compiler is wrong.)

regards,
dan carpenter