2023-01-17 03:59:16

by Judy Hsiao

Subject: [PATCH v3] arm64: dts: qcom: sc7280: add display port audio

1. Add DisplayPort sound node and lpass_cpu node.

2. Adjust the dai-link order to make the order to
be consistent with sc7280-herobrine-audio-rt5682-3mic.dtsi.

Signed-off-by: Judy Hsiao <[email protected]>

---

Changes in v3:
- Add more detail in the commit message.

Changes in v2:
- Fix the commit message format.

.../qcom/sc7280-herobrine-audio-rt5682.dtsi | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
index af685bc35e10..69e7aa7b2f6c 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
@@ -33,9 +33,22 @@ codec {
};

dai-link@1 {
- link-name = "ALC5682";
+ link-name = "DisplayPort";
reg = <1>;

+ cpu {
+ sound-dai = <&lpass_cpu LPASS_DP_RX>;
+ };
+
+ codec {
+ sound-dai = <&mdss_dp>;
+ };
+ };
+
+ dai-link@2 {
+ link-name = "ALC5682";
+ reg = <2>;
+
cpu {
sound-dai = <&lpass_cpu MI2S_PRIMARY>;
};
@@ -92,6 +105,10 @@ dai-link@1 {
reg = <MI2S_SECONDARY>;
qcom,playback-sd-lines = <0>;
};
+
+ dai-link@5 {
+ reg = <LPASS_DP_RX>;
+ };
};

/* PINCTRL - ADDITIONS TO NODES IN PARENT DEVICE TREE FILES */
--
2.39.0.314.g84b9a713c41-goog

2023-01-17 23:47:49

by Doug Anderson

Subject: Re: [PATCH v3] arm64: dts: qcom: sc7280: add display port audio

Hi,

On Mon, Jan 16, 2023 at 6:42 PM Judy Hsiao <[email protected]> wrote:
>
> 1. Add DisplayPort sound node and lpass_cpu node.
>
> 2. Adjust the dai-link order to make the order to
> be consistent with sc7280-herobrine-audio-rt5682-3mic.dtsi.
>
> Signed-off-by: Judy Hsiao <[email protected]>
>
> ---
>
> Changes in v3:
> - Add more detail in the commit message.
>
> Changes in v2:
> - Fix the commit message format.
>
> .../qcom/sc7280-herobrine-audio-rt5682.dtsi | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)

nit: Your ${SUBJECT} needs to make it obvious what this is changing. Like maybe:

arm64: dts: qcom: sc7280: add DP audio to herobrine rt5682 1-mic dtsi

Other than that this looks good to me:

Reviewed-by: Douglas Anderson <[email protected]>