2023-01-17 03:08:49

by ye.xingchen

Subject: [PATCH] thermal/int340x_thermal: Convert to use sysfs_emit_at() API

From: ye xingchen <[email protected]>

Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: ye xingchen <[email protected]>
---
.../thermal/intel/int340x_thermal/int3400_thermal.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
index db8a6f63657d..c1fc4a78607c 100644
--- a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
+++ b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
@@ -130,10 +130,7 @@ static ssize_t available_uuids_show(struct device *dev,

for (i = 0; i < INT3400_THERMAL_MAXIMUM_UUID; i++) {
if (priv->uuid_bitmap & (1 << i))
- length += scnprintf(&buf[length],
- PAGE_SIZE - length,
- "%s\n",
- int3400_thermal_uuids[i]);
+ length += sysfs_emit_at(buf, length, int3400_thermal_uuids[i]);
}

return length;
@@ -151,10 +148,7 @@ static ssize_t current_uuid_show(struct device *dev,

for (i = 0; i <= INT3400_THERMAL_CRITICAL; i++) {
if (priv->os_uuid_mask & BIT(i))
- length += scnprintf(&buf[length],
- PAGE_SIZE - length,
- "%s\n",
- int3400_thermal_uuids[i]);
+ length += sysfs_emit_at(buf, length, int3400_thermal_uuids[i]);
}

if (length)
--
2.25.1

2023-01-20 17:58:54

by Rafael J. Wysocki

Subject: Re: [PATCH] thermal/int340x_thermal: Convert to use sysfs_emit_at() API

On Tue, Jan 17, 2023 at 3:42 AM <[email protected]> wrote:
>
> From: ye xingchen <[email protected]>
>
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
>
> Signed-off-by: ye xingchen <[email protected]>
> ---
> .../thermal/intel/int340x_thermal/int3400_thermal.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> index db8a6f63657d..c1fc4a78607c 100644
> --- a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> +++ b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> @@ -130,10 +130,7 @@ static ssize_t available_uuids_show(struct device *dev,
>
> for (i = 0; i < INT3400_THERMAL_MAXIMUM_UUID; i++) {
> if (priv->uuid_bitmap & (1 << i))
> - length += scnprintf(&buf[length],
> - PAGE_SIZE - length,
> - "%s\n",
> - int3400_thermal_uuids[i]);
> + length += sysfs_emit_at(buf, length, int3400_thermal_uuids[i]);
> }
>
> return length;
> @@ -151,10 +148,7 @@ static ssize_t current_uuid_show(struct device *dev,
>
> for (i = 0; i <= INT3400_THERMAL_CRITICAL; i++) {
> if (priv->os_uuid_mask & BIT(i))
> - length += scnprintf(&buf[length],
> - PAGE_SIZE - length,
> - "%s\n",
> - int3400_thermal_uuids[i]);
> + length += sysfs_emit_at(buf, length, int3400_thermal_uuids[i]);
> }
>
> if (length)
> --

Applied as 6.3 material with a modified changelog, thanks!