2023-01-17 12:40:16

by Koba Ko

Subject: [PATCH] platform/x86: dell-wmi: Add a keymap for KEY_MUTE in type 0x0010 table

Some platforms send the speaker-mute key from EC. dell-wmi can't
recognize it.

Add a new keymap for KEY_MUTE in type 0x0010 table.

Signed-off-by: Koba Ko <[email protected]>
---
drivers/platform/x86/dell/dell-wmi-base.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/platform/x86/dell/dell-wmi-base.c b/drivers/platform/x86/dell/dell-wmi-base.c
index 0a259a27459f6..502783a7adb11 100644
--- a/drivers/platform/x86/dell/dell-wmi-base.c
+++ b/drivers/platform/x86/dell/dell-wmi-base.c
@@ -261,6 +261,9 @@ static const struct key_entry dell_wmi_keymap_type_0010[] = {
{ KE_KEY, 0x57, { KEY_BRIGHTNESSDOWN } },
{ KE_KEY, 0x58, { KEY_BRIGHTNESSUP } },

+ /*Speaker Mute*/
+ { KE_KEY, 0x109, { KEY_MUTE} },
+
/* Mic mute */
{ KE_KEY, 0x150, { KEY_MICMUTE } },

--
2.34.1

2023-01-23 13:30:40

by Hans de Goede

Subject: Re: [PATCH] platform/x86: dell-wmi: Add a keymap for KEY_MUTE in type 0x0010 table

Hi,

On 1/17/23 13:34, Koba Ko wrote:
> Some platforms send the speaker-mute key from EC. dell-wmi can't
> recognize it.
>
> Add a new keymap for KEY_MUTE in type 0x0010 table.
>
> Signed-off-by: Koba Ko <[email protected]>

Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> ---
> drivers/platform/x86/dell/dell-wmi-base.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/platform/x86/dell/dell-wmi-base.c b/drivers/platform/x86/dell/dell-wmi-base.c
> index 0a259a27459f6..502783a7adb11 100644
> --- a/drivers/platform/x86/dell/dell-wmi-base.c
> +++ b/drivers/platform/x86/dell/dell-wmi-base.c
> @@ -261,6 +261,9 @@ static const struct key_entry dell_wmi_keymap_type_0010[] = {
> { KE_KEY, 0x57, { KEY_BRIGHTNESSDOWN } },
> { KE_KEY, 0x58, { KEY_BRIGHTNESSUP } },
>
> + /*Speaker Mute*/
> + { KE_KEY, 0x109, { KEY_MUTE} },
> +
> /* Mic mute */
> { KE_KEY, 0x150, { KEY_MICMUTE } },
>