2023-01-18 01:28:57

by Deming Wang

[permalink] [raw]
Subject: [PATCH] mm/highmem: fix spelling mistakeo

Substitute occurrencies of "higmem" with "highmem".

Signed-off-by: Deming Wang <[email protected]>
---
Documentation/mm/highmem.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/mm/highmem.rst b/Documentation/mm/highmem.rst
index 59d1078f53df..7da4a0d175f0 100644
--- a/Documentation/mm/highmem.rst
+++ b/Documentation/mm/highmem.rst
@@ -83,7 +83,7 @@ list shows them in order of preference of use.
for pages which are known to not come from ZONE_HIGHMEM. However, it is
always safe to use kmap_local_page() / kunmap_local().

- While it is significantly faster than kmap(), for the higmem case it
+ While it is significantly faster than kmap(), for the highmem case it
comes with restrictions about the pointers validity. Contrary to kmap()
mappings, the local mappings are only valid in the context of the caller
and cannot be handed to other contexts. This implies that users must
--
2.27.0


2023-01-18 02:37:06

by Bagas Sanjaya

[permalink] [raw]
Subject: Re: [PATCH] mm/highmem: fix spelling mistakeo

On Tue, Jan 17, 2023 at 07:43:56PM -0500, Deming Wang wrote:
> Substitute occurrencies of "higmem" with "highmem".
>
> Signed-off-by: Deming Wang <[email protected]>
> ---
> Documentation/mm/highmem.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/mm/highmem.rst b/Documentation/mm/highmem.rst
> index 59d1078f53df..7da4a0d175f0 100644
> --- a/Documentation/mm/highmem.rst
> +++ b/Documentation/mm/highmem.rst
> @@ -83,7 +83,7 @@ list shows them in order of preference of use.
> for pages which are known to not come from ZONE_HIGHMEM. However, it is
> always safe to use kmap_local_page() / kunmap_local().
>
> - While it is significantly faster than kmap(), for the higmem case it
> + While it is significantly faster than kmap(), for the highmem case it
> comes with restrictions about the pointers validity. Contrary to kmap()
> mappings, the local mappings are only valid in the context of the caller
> and cannot be handed to other contexts. This implies that users must

Are you sure you have seen the other occurences of higmem in the same
doc? If so, do s/higmem/highmem/g.

Also, the patch subject prefix should have been Documentation: mm:
highmem, and also s/mistakeo/mistake/ in the subject.

Thanks.

--
An old man doll... just what I always wanted! - Clara


Attachments:
(No filename) (1.34 kB)
signature.asc (235.00 B)
Download all attachments

2023-01-18 03:22:43

by Deming Wang

[permalink] [raw]
Subject: 答复: [PATCH] mm/highmem: fix spelling mist akeo

Hi,

I find only one typo about higmem. And I have modified the subject.

Thanks

> send: Bagas Sanjaya <[email protected]>
> time: 2023年1月18日 10:21
> to: tomorrow Wang (王德明) <[email protected]>;
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]
> subject: Re: [PATCH] mm/highmem: fix spelling mistakeo
>
> On Tue, Jan 17, 2023 at 07:43:56PM -0500, Deming Wang wrote:
> > Substitute occurrencies of "higmem" with "highmem".
> >
> > Signed-off-by: Deming Wang <[email protected]>
> > ---
> > Documentation/mm/highmem.rst | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/mm/highmem.rst
> > b/Documentation/mm/highmem.rst index 59d1078f53df..7da4a0d175f0
> 100644
> > --- a/Documentation/mm/highmem.rst
> > +++ b/Documentation/mm/highmem.rst
> > @@ -83,7 +83,7 @@ list shows them in order of preference of use.
> > for pages which are known to not come from ZONE_HIGHMEM. However,
> it is
> > always safe to use kmap_local_page() / kunmap_local().
> >
> > - While it is significantly faster than kmap(), for the higmem case
> > it
> > + While it is significantly faster than kmap(), for the highmem case
> > + it
> > comes with restrictions about the pointers validity. Contrary to kmap()
> > mappings, the local mappings are only valid in the context of the caller
> > and cannot be handed to other contexts. This implies that users
> > must
>
> Are you sure you have seen the other occurences of higmem in the same doc?
> If so, do s/higmem/highmem/g.
>
> Also, the patch subject prefix should have been Documentation: mm:
> highmem, and also s/mistakeo/mistake/ in the subject.
>
> Thanks.
>
> --
> An old man doll... just what I always wanted! - Clara


Attachments:
0001-Documentation-mm-use-s-higmem-highmem-fix-typo-for-h.patch (1.15 kB)
smime.p7s (3.69 kB)
Download all attachments

2023-01-19 02:19:03

by Bagas Sanjaya

[permalink] [raw]
Subject: Re: 答复: [PATCH] mm/highmem: fix spelli ng mistakeo

On 1/18/23 09:55, tomorrow Wang (王德明) wrote:
> Hi,
>
> I find only one typo about higmem. And I have modified the subject.
>

You send your patch as attachment, please send it inline instead
with git-send-email(1).

Also, please don't top-post; reply inline with appropriate context
instead.

Thanks.

--
An old man doll... just what I always wanted! - Clara

2023-01-19 12:29:15

by Fabio M. De Francesco

[permalink] [raw]
Subject: Re: [PATCH] mm/highmem: fix spelling mistakeo

On mercoled? 18 gennaio 2023 01:43:56 CET Deming Wang wrote:
> Substitute occurrencies of "higmem" with "highmem".

s/occurrencies/occurrences

> Signed-off-by: Deming Wang <[email protected]>
> ---
> Documentation/mm/highmem.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/mm/highmem.rst b/Documentation/mm/highmem.rst
> index 59d1078f53df..7da4a0d175f0 100644
> --- a/Documentation/mm/highmem.rst
> +++ b/Documentation/mm/highmem.rst
> @@ -83,7 +83,7 @@ list shows them in order of preference of use.
> for pages which are known to not come from ZONE_HIGHMEM. However, it is
> always safe to use kmap_local_page() / kunmap_local().
>
> - While it is significantly faster than kmap(), for the higmem case it
> + While it is significantly faster than kmap(), for the highmem case it
> comes with restrictions about the pointers validity. Contrary to kmap()
> mappings, the local mappings are only valid in the context of the caller
> and cannot be handed to other contexts. This implies that users must
> --
> 2.27.0

I think you missed a patch which is already in Andrew's -mm-unstable tree:

[PATCH] mm: Fix two spelling mistakes in highmem.h
https://lore.kernel.org/lkml/[email protected]/

Fabio