2023-01-19 10:02:14

by ye.xingchen

[permalink] [raw]
Subject: [PATCH] i2c: versatile: Use devm_platform_get_and_ioremap_resource()

From: ye xingchen <[email protected]>

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: ye xingchen <[email protected]>
---
drivers/i2c/busses/i2c-versatile.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/i2c/busses/i2c-versatile.c b/drivers/i2c/busses/i2c-versatile.c
index 1ab419f8fa52..219aa8dd4454 100644
--- a/drivers/i2c/busses/i2c-versatile.c
+++ b/drivers/i2c/busses/i2c-versatile.c
@@ -64,15 +64,13 @@ static const struct i2c_algo_bit_data i2c_versatile_algo = {
static int i2c_versatile_probe(struct platform_device *dev)
{
struct i2c_versatile *i2c;
- struct resource *r;
int ret;

i2c = devm_kzalloc(&dev->dev, sizeof(struct i2c_versatile), GFP_KERNEL);
if (!i2c)
return -ENOMEM;

- r = platform_get_resource(dev, IORESOURCE_MEM, 0);
- i2c->base = devm_ioremap_resource(&dev->dev, r);
+ i2c->base = devm_platform_get_and_ioremap_resource(dev, 0, NULL);
if (IS_ERR(i2c->base))
return PTR_ERR(i2c->base);

--
2.25.1


2023-06-10 13:59:54

by Andi Shyti

[permalink] [raw]
Subject: Re: [PATCH] i2c: versatile: Use devm_platform_get_and_ioremap_resource()

Hi Ye,

On Thu, Jan 19, 2023 at 05:21:23PM +0800, [email protected] wrote:
> From: ye xingchen <[email protected]>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: ye xingchen <[email protected]>

Reviewed-by: Andi Shyti <[email protected]>

Thanks,
Andi

2023-06-10 19:06:53

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH] i2c: versatile: Use devm_platform_get_and_ioremap_resource()

On Thu, Jan 19, 2023 at 10:21 AM <[email protected]> wrote:

> From: ye xingchen <[email protected]>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: ye xingchen <[email protected]>

Makes sense.
Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2023-06-14 09:18:53

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH] i2c: versatile: Use devm_platform_get_and_ioremap_resource()

On Thu, Jan 19, 2023 at 05:21:23PM +0800, [email protected] wrote:
> From: ye xingchen <[email protected]>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: ye xingchen <[email protected]>

Applied to for-next, thanks!


Attachments:
(No filename) (388.00 B)
signature.asc (849.00 B)
Download all attachments