2023-01-21 11:33:57

by Robert Marko

Subject: [PATCH 3/4] cpufreq: qcom-nvmem: use SoC ID-s from bindings

SMEM SoC ID-s are now stored in DT bindings so lets use those instead of
defining them in the driver again.

Signed-off-by: Robert Marko <[email protected]>
---
drivers/cpufreq/qcom-cpufreq-nvmem.c | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/drivers/cpufreq/qcom-cpufreq-nvmem.c b/drivers/cpufreq/qcom-cpufreq-nvmem.c
index c0a7841a56c1..da55d2e1925a 100644
--- a/drivers/cpufreq/qcom-cpufreq-nvmem.c
+++ b/drivers/cpufreq/qcom-cpufreq-nvmem.c
@@ -30,12 +30,7 @@
#include <linux/soc/qcom/smem.h>
#include <linux/soc/qcom/socinfo.h>

-enum _msm_id {
- MSM8996V3 = 0xF6ul,
- APQ8096V3 = 0x123ul,
- MSM8996SG = 0x131ul,
- APQ8096SG = 0x138ul,
-};
+#include <dt-bindings/arm/qcom,ids.h>

enum _msm8996_version {
MSM8996_V3,
@@ -150,12 +145,12 @@ static enum _msm8996_version qcom_cpufreq_get_msm_id(void)
return NUM_OF_MSM8996_VERSIONS;

switch (info->id) {
- case MSM8996V3:
- case APQ8096V3:
+ case QCOM_ID_MSM8996:
+ case QCOM_ID_APQ8096:
version = MSM8996_V3;
break;
- case MSM8996SG:
- case APQ8096SG:
+ case QCOM_ID_MSM8996SG:
+ case QCOM_ID_APQ8096SG:
version = MSM8996_SG;
break;
default:
--
2.39.1

2023-01-23 16:59:57

by Konrad Dybcio

Subject: Re: [PATCH 3/4] cpufreq: qcom-nvmem: use SoC ID-s from bindings

On 21.01.2023 12:29, Robert Marko wrote:
> SMEM SoC ID-s are now stored in DT bindings so lets use those instead of
> defining them in the driver again.
>
> Signed-off-by: Robert Marko <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> drivers/cpufreq/qcom-cpufreq-nvmem.c | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/cpufreq/qcom-cpufreq-nvmem.c b/drivers/cpufreq/qcom-cpufreq-nvmem.c
> index c0a7841a56c1..da55d2e1925a 100644
> --- a/drivers/cpufreq/qcom-cpufreq-nvmem.c
> +++ b/drivers/cpufreq/qcom-cpufreq-nvmem.c
> @@ -30,12 +30,7 @@
> #include <linux/soc/qcom/smem.h>
> #include <linux/soc/qcom/socinfo.h>
>
> -enum _msm_id {
> - MSM8996V3 = 0xF6ul,
> - APQ8096V3 = 0x123ul,
> - MSM8996SG = 0x131ul,
> - APQ8096SG = 0x138ul,
> -};
> +#include <dt-bindings/arm/qcom,ids.h>
>
> enum _msm8996_version {
> MSM8996_V3,
> @@ -150,12 +145,12 @@ static enum _msm8996_version qcom_cpufreq_get_msm_id(void)
> return NUM_OF_MSM8996_VERSIONS;
>
> switch (info->id) {
> - case MSM8996V3:
> - case APQ8096V3:
> + case QCOM_ID_MSM8996:
> + case QCOM_ID_APQ8096:
> version = MSM8996_V3;
> break;
> - case MSM8996SG:
> - case APQ8096SG:
> + case QCOM_ID_MSM8996SG:
> + case QCOM_ID_APQ8096SG:
> version = MSM8996_SG;
> break;
> default:

2023-02-06 20:38:02

by Bjorn Andersson

Subject: Re: [PATCH 3/4] cpufreq: qcom-nvmem: use SoC ID-s from bindings

On Sat, Jan 21, 2023 at 12:29:46PM +0100, Robert Marko wrote:
> SMEM SoC ID-s are now stored in DT bindings so lets use those instead of
> defining them in the driver again.
>
> Signed-off-by: Robert Marko <[email protected]>

Reviewed-by: Bjorn Andersson <[email protected]>

> ---
> drivers/cpufreq/qcom-cpufreq-nvmem.c | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/cpufreq/qcom-cpufreq-nvmem.c b/drivers/cpufreq/qcom-cpufreq-nvmem.c
> index c0a7841a56c1..da55d2e1925a 100644
> --- a/drivers/cpufreq/qcom-cpufreq-nvmem.c
> +++ b/drivers/cpufreq/qcom-cpufreq-nvmem.c
> @@ -30,12 +30,7 @@
> #include <linux/soc/qcom/smem.h>
> #include <linux/soc/qcom/socinfo.h>
>
> -enum _msm_id {
> - MSM8996V3 = 0xF6ul,
> - APQ8096V3 = 0x123ul,
> - MSM8996SG = 0x131ul,
> - APQ8096SG = 0x138ul,
> -};
> +#include <dt-bindings/arm/qcom,ids.h>
>
> enum _msm8996_version {
> MSM8996_V3,
> @@ -150,12 +145,12 @@ static enum _msm8996_version qcom_cpufreq_get_msm_id(void)
> return NUM_OF_MSM8996_VERSIONS;
>
> switch (info->id) {
> - case MSM8996V3:
> - case APQ8096V3:
> + case QCOM_ID_MSM8996:
> + case QCOM_ID_APQ8096:
> version = MSM8996_V3;
> break;
> - case MSM8996SG:
> - case APQ8096SG:
> + case QCOM_ID_MSM8996SG:
> + case QCOM_ID_APQ8096SG:
> version = MSM8996_SG;
> break;
> default:
> --
> 2.39.1
>