2023-01-21 20:31:06

by Markuss Broks

[permalink] [raw]
Subject: [PATCH v2 0/2] Add support for Samsung Galaxy S5 (Exynos)

Samsung Galaxy S5 (Exynos) is a mobile phone released in 2014.
It has an Exynos5422 platform. This version of Galaxy S5 is only
capable of 3G communication using the Intel modem, while the
LTE version of the device (klte) has a Qualcomm Snapdragon SoC.

Currently, internal eMMC, USB, regulators on a PMIC, and touchscreen
are enabled in the device-tree.

It also has the following peripherals:

- 5" 1080p S6E3FA2 DSI display,
- Cypress StreetFighter touch buttons,
- Broadcom BCM4354 wireless connectivity module,
- Intel XMM6360 3G modem,
- STM32F401 serving as a sensor hub,
- Validify Solutions VFS61 series fingerprint sensor,
- Lattice ICE401M FPGA as an IRDA controller,
- Maxim MAX86900 heart rate sensor,
- NXP PN547 NFC controller,
- Wolfson WM5110 Audio DSP,
- Broadcom BCM4753 GPS radio,
- Maxim MAX77804 PMIC,
- Silicon Image SII8240 MHL controller,
- TI LP5562 LED driver

Cc: Mark Brown <[email protected]>

v1 -> v2:
- use better subject prefixes
- rename Galaxy S5 (Exynos) to Galaxy S5 (SM-G900H)
- align the compatibles and clock output names
- reorder the includes
- generic node name for regulator-tsp-vdd-en
- GPIO flag for regulator
- rename all the regulators, leaving the voltage values only where
it makes sense (e.g. on 3V3 and 1V8 supplies for the HRM)

Markuss Broks (2):
Documentation: devicetree: bindings: Add compatible for Samsung Galaxy
S5 (Exynos)
arm: dts: Add device-tree for Samsung Galaxy S5 (Exynos)

.../bindings/arm/samsung/samsung-boards.yaml | 1 +
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/exynos5422-samsung-k3g.dts | 676 ++++++++++++++++++
3 files changed, 678 insertions(+)
create mode 100644 arch/arm/boot/dts/exynos5422-samsung-k3g.dts

--
2.39.0


2023-01-21 20:36:55

by Markuss Broks

[permalink] [raw]
Subject: [PATCH v2 1/2] dt-bindings: arm: samsung: Add compatible for Samsung Galaxy S5 (SM-G900H)

Add the compatible for k3g in the Samsung Exynos5800 boards section.

Signed-off-by: Markuss Broks <[email protected]>
---
.../devicetree/bindings/arm/samsung/samsung-boards.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
index faea33e4f731..deb2cf971871 100644
--- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
+++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
@@ -171,6 +171,7 @@ properties:
- hardkernel,odroid-xu3-lite # Hardkernel Odroid XU3 Lite
- hardkernel,odroid-xu4 # Hardkernel Odroid XU4
- hardkernel,odroid-hc1 # Hardkernel Odroid HC1
+ - samsung,k3g # Samsung Galaxy S5 (SM-G900H)
- const: samsung,exynos5800
- const: samsung,exynos5

--
2.39.0

2023-01-23 09:59:42

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2 0/2] Add support for Samsung Galaxy S5 (Exynos)

On 21/01/2023 21:19, Markuss Broks wrote:
> Samsung Galaxy S5 (Exynos) is a mobile phone released in 2014.
> It has an Exynos5422 platform. This version of Galaxy S5 is only
> capable of 3G communication using the Intel modem, while the
> LTE version of the device (klte) has a Qualcomm Snapdragon SoC.
>
> Currently, internal eMMC, USB, regulators on a PMIC, and touchscreen
> are enabled in the device-tree.
>
> It also has the following peripherals:
>
> - 5" 1080p S6E3FA2 DSI display,
> - Cypress StreetFighter touch buttons,
> - Broadcom BCM4354 wireless connectivity module,
> - Intel XMM6360 3G modem,
> - STM32F401 serving as a sensor hub,
> - Validify Solutions VFS61 series fingerprint sensor,
> - Lattice ICE401M FPGA as an IRDA controller,
> - Maxim MAX86900 heart rate sensor,
> - NXP PN547 NFC controller,
> - Wolfson WM5110 Audio DSP,
> - Broadcom BCM4753 GPS radio,
> - Maxim MAX77804 PMIC,
> - Silicon Image SII8240 MHL controller,
> - TI LP5562 LED driver
>
> Cc: Mark Brown <[email protected]>
>
> v1 -> v2:
> - use better subject prefixes
> - rename Galaxy S5 (Exynos) to Galaxy S5 (SM-G900H)
> - align the compatibles and clock output names
> - reorder the includes
> - generic node name for regulator-tsp-vdd-en
> - GPIO flag for regulator
> - rename all the regulators, leaving the voltage values only where
> it makes sense (e.g. on 3V3 and 1V8 supplies for the HRM)

I got two v2 patchsets from you. No clue which one is correct. Please
send v3 if there were differences. Otherwise please annotate somehow...

Best regards,
Krzysztof


2023-01-23 15:25:29

by Markuss Broks

[permalink] [raw]
Subject: Re: [PATCH v2 0/2] Add support for Samsung Galaxy S5 (Exynos)

Hi Krzysztof,

On 1/23/23 11:59, Krzysztof Kozlowski wrote:
> On 21/01/2023 21:19, Markuss Broks wrote:
>> Samsung Galaxy S5 (Exynos) is a mobile phone released in 2014.
>> It has an Exynos5422 platform. This version of Galaxy S5 is only
>> capable of 3G communication using the Intel modem, while the
>> LTE version of the device (klte) has a Qualcomm Snapdragon SoC.
>>
>> Currently, internal eMMC, USB, regulators on a PMIC, and touchscreen
>> are enabled in the device-tree.
>>
>> It also has the following peripherals:
>>
>> - 5" 1080p S6E3FA2 DSI display,
>> - Cypress StreetFighter touch buttons,
>> - Broadcom BCM4354 wireless connectivity module,
>> - Intel XMM6360 3G modem,
>> - STM32F401 serving as a sensor hub,
>> - Validify Solutions VFS61 series fingerprint sensor,
>> - Lattice ICE401M FPGA as an IRDA controller,
>> - Maxim MAX86900 heart rate sensor,
>> - NXP PN547 NFC controller,
>> - Wolfson WM5110 Audio DSP,
>> - Broadcom BCM4753 GPS radio,
>> - Maxim MAX77804 PMIC,
>> - Silicon Image SII8240 MHL controller,
>> - TI LP5562 LED driver
>>
>> Cc: Mark Brown <[email protected]>
>>
>> v1 -> v2:
>> - use better subject prefixes
>> - rename Galaxy S5 (Exynos) to Galaxy S5 (SM-G900H)
>> - align the compatibles and clock output names
>> - reorder the includes
>> - generic node name for regulator-tsp-vdd-en
>> - GPIO flag for regulator
>> - rename all the regulators, leaving the voltage values only where
>> it makes sense (e.g. on 3V3 and 1V8 supplies for the HRM)
> I got two v2 patchsets from you. No clue which one is correct. Please
> send v3 if there were differences. Otherwise please annotate somehow...
Sorry about that, the first time I sent v2 it lacked the v2 tag in
actual patch letters, but contained the tag in the cover letter, so I
thought it would make confusion, so I fixed it and sent it properly. The
patchsets are identical otherwise.
>
> Best regards,
> Krzysztof
>
- Markuss