2023-01-23 10:16:29

by Johan Hovold

Subject: [PATCH] arm64: dts: qcom: sm8550: fix USB-DP PHY resets

The USB-DP PHY resets have been switched.

Fixes: 7f7e5c1b037f ("arm64: dts: qcom: sm8550: Add USB PHYs and controller nodes")
Signed-off-by: Johan Hovold <[email protected]>
---
arch/arm64/boot/dts/qcom/sm8550.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
index 6ff135191ee0..2f453dc00852 100644
--- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
@@ -2395,8 +2395,8 @@ usb_dp_qmpphy: phy@88e8000 {

power-domains = <&gcc USB3_PHY_GDSC>;

- resets = <&gcc GCC_USB3_DP_PHY_PRIM_BCR>,
- <&gcc GCC_USB3_PHY_PRIM_BCR>;
+ resets = <&gcc GCC_USB3_PHY_PRIM_BCR>,
+ <&gcc GCC_USB3_DP_PHY_PRIM_BCR>;
reset-names = "phy", "common";

#clock-cells = <1>;
--
2.39.1

2023-01-23 12:33:23

by Konrad Dybcio

Subject: Re: [PATCH] arm64: dts: qcom: sm8550: fix USB-DP PHY resets

On 23.01.2023 11:16, Johan Hovold wrote:
> The USB-DP PHY resets have been switched.
>
> Fixes: 7f7e5c1b037f ("arm64: dts: qcom: sm8550: Add USB PHYs and controller nodes")
> Signed-off-by: Johan Hovold <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/sm8550.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> index 6ff135191ee0..2f453dc00852 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> @@ -2395,8 +2395,8 @@ usb_dp_qmpphy: phy@88e8000 {
>
> power-domains = <&gcc USB3_PHY_GDSC>;
>
> - resets = <&gcc GCC_USB3_DP_PHY_PRIM_BCR>,
> - <&gcc GCC_USB3_PHY_PRIM_BCR>;
> + resets = <&gcc GCC_USB3_PHY_PRIM_BCR>,
> + <&gcc GCC_USB3_DP_PHY_PRIM_BCR>;
> reset-names = "phy", "common";
>
> #clock-cells = <1>;

2023-01-23 12:41:17

by Abel Vesa

Subject: Re: [PATCH] arm64: dts: qcom: sm8550: fix USB-DP PHY resets

On 23-01-23 11:16:07, Johan Hovold wrote:
> The USB-DP PHY resets have been switched.
>
> Fixes: 7f7e5c1b037f ("arm64: dts: qcom: sm8550: Add USB PHYs and controller nodes")
> Signed-off-by: Johan Hovold <[email protected]>

Reviewed-by: Abel Vesa <[email protected]>

> ---
> arch/arm64/boot/dts/qcom/sm8550.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> index 6ff135191ee0..2f453dc00852 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> @@ -2395,8 +2395,8 @@ usb_dp_qmpphy: phy@88e8000 {
>
> power-domains = <&gcc USB3_PHY_GDSC>;
>
> - resets = <&gcc GCC_USB3_DP_PHY_PRIM_BCR>,
> - <&gcc GCC_USB3_PHY_PRIM_BCR>;
> + resets = <&gcc GCC_USB3_PHY_PRIM_BCR>,
> + <&gcc GCC_USB3_DP_PHY_PRIM_BCR>;
> reset-names = "phy", "common";
>
> #clock-cells = <1>;
> --
> 2.39.1
>

2023-02-09 04:25:37

by Bjorn Andersson

Subject: Re: [PATCH] arm64: dts: qcom: sm8550: fix USB-DP PHY resets

On Mon, 23 Jan 2023 11:16:07 +0100, Johan Hovold wrote:
> The USB-DP PHY resets have been switched.
>
>

Applied, thanks!

[1/1] arm64: dts: qcom: sm8550: fix USB-DP PHY resets
commit: cd649ac4059bd7221e5a1c1370db749c1c9d82f8

Best regards,
--
Bjorn Andersson <[email protected]>