2023-01-24 12:59:37

by Tom Rix

Subject: [PATCH] io_uring: initialize count variable to 0

The clang build fails with
io_uring/io_uring.c:1240:3: error: variable 'count' is uninitialized
when used here [-Werror,-Wuninitialized]
count += handle_tw_list(node, &ctx, &uring_locked, &fake);
^~~~~

The commit listed in the fixes: removed the initialization of count.

Fixes: b5b57128d0cd ("io_uring: refactor tctx_task_work")
Signed-off-by: Tom Rix <[email protected]>
---
io_uring/io_uring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c
index 734d074cdd94..4cb409ae9840 100644
--- a/io_uring/io_uring.c
+++ b/io_uring/io_uring.c
@@ -1227,7 +1227,7 @@ void tctx_task_work(struct callback_head *cb)
struct llist_node fake = {};
struct llist_node *node;
unsigned int loops = 0;
- unsigned int count;
+ unsigned int count = 0;

if (unlikely(current->flags & PF_EXITING)) {
io_fallback_tw(tctx);
--
2.26.3

2023-01-24 14:05:06

by Pavel Begunkov

Subject: Re: [PATCH] io_uring: initialize count variable to 0

On 1/24/23 12:58, Tom Rix wrote:
> The clang build fails with
> io_uring/io_uring.c:1240:3: error: variable 'count' is uninitialized
> when used here [-Werror,-Wuninitialized]
> count += handle_tw_list(node, &ctx, &uring_locked, &fake);
> ^~~~~
>
> The commit listed in the fixes: removed the initialization of count.

My bad. The patch looks good, thanks


> Fixes: b5b57128d0cd ("io_uring: refactor tctx_task_work")
> Signed-off-by: Tom Rix <[email protected]>
> ---
> io_uring/io_uring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c
> index 734d074cdd94..4cb409ae9840 100644
> --- a/io_uring/io_uring.c
> +++ b/io_uring/io_uring.c
> @@ -1227,7 +1227,7 @@ void tctx_task_work(struct callback_head *cb)
> struct llist_node fake = {};
> struct llist_node *node;
> unsigned int loops = 0;
> - unsigned int count;
> + unsigned int count = 0;
>
> if (unlikely(current->flags & PF_EXITING)) {
> io_fallback_tw(tctx);

--
Pavel Begunkov

2023-01-24 14:11:23

by Jens Axboe

Subject: Re: [PATCH] io_uring: initialize count variable to 0

On Tue, 24 Jan 2023 04:58:05 -0800, Tom Rix wrote:
> The clang build fails with
> io_uring/io_uring.c:1240:3: error: variable 'count' is uninitialized
> when used here [-Werror,-Wuninitialized]
> count += handle_tw_list(node, &ctx, &uring_locked, &fake);
> ^~~~~
>
> The commit listed in the fixes: removed the initialization of count.
>
> [...]

Applied, thanks!

[1/1] io_uring: initialize count variable to 0
commit: 7a9e93db01f44a8d084c93648981cbc1535a734d

Best regards,
--
Jens Axboe